Skip to content

8345598: Upgrade NSS binaries for interop tests#23594

Closed
mpdonova wants to merge 1 commit intoopenjdk:masterfrom
mpdonova:nss3107
Closed

8345598: Upgrade NSS binaries for interop tests#23594
mpdonova wants to merge 1 commit intoopenjdk:masterfrom
mpdonova:nss3107

Conversation

@mpdonova
Copy link
Contributor

@mpdonova mpdonova commented Feb 12, 2025

This is a trivial PR to update the version of NSS used for pkcs11 tests.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8345598: Upgrade NSS binaries for interop tests (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23594/head:pull/23594
$ git checkout pull/23594

Update a local copy of the PR:
$ git checkout pull/23594
$ git pull https://git.openjdk.org/jdk.git pull/23594/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23594

View PR using the GUI difftool:
$ git pr show -t 23594

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23594.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 12, 2025

👋 Welcome back mdonovan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 12, 2025

@mpdonova This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8345598: Upgrade NSS binaries for interop tests

Reviewed-by: weijun, rhalade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 139 new commits pushed to the master branch:

  • dea7a9f: 8350516: Update model numbers for ECore-based cpus
  • 5023971: 8267068: Incomplete @throws javadoc for various javax.crypto.spec classes
  • 08bc59d: 8138614: (spec str) StringBuffer and StringBuilder methods improperly require "new" String to be returned
  • b17c0b6: 8350585: InlineSecondarySupersTest must be guarded on ppc64 by COMPILER2
  • 62f39bd: 8350636: Potential null-pointer dereference in MallocSiteTable::new_entry
  • cfeb7d6: 8350497: os::create_thread unify init thread attributes part across UNIX platforms
  • 8cfebc4: 8350571: Remove mention of Tonga test suite from JMX tests
  • c413549: 8349860: Make Class.isArray(), Class.isInterface() and Class.isPrimitive() non-native
  • a9c9f7f: 8192647: GClocker induced GCs can starve threads requiring memory leading to OOME
  • aa70f0a: 8347348: Clarify that the HTTP server in jdk.httpserver module is not a full featured server
  • ... and 129 more: https://git.openjdk.org/jdk/compare/ed17c55ea34b3b6009dab11d64f21e0b7af3d701...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 12, 2025
@openjdk
Copy link

openjdk bot commented Feb 12, 2025

@mpdonova The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Feb 12, 2025
@mlbridge
Copy link

mlbridge bot commented Feb 12, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 14, 2025
@mpdonova
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Feb 26, 2025

Going to push as commit 0f82268.
Since your change was applied there have been 159 commits pushed to the master branch:

  • ea2c923: 8323807: Async UL: Add a stalling mode to async UL
  • e7d4b36: 8350667: Remove startThread_lock() and _startThread_lock on AIX
  • 1e18fff: 8328473: StringTable and SymbolTable statistics delay time to safepoint
  • a0dd565: 8350643: G1: Make loop iteration variable type correspond to limit in G1SurvRateGroup
  • aac9cb4: 8349906: G1: Improve initial survivor rate for newly used young regions
  • a431046: 8350518: org.openjdk.bench.java.util.TreeMapUpdate.compute fails with "java.lang.IllegalArgumentException: key out of range"
  • a70eba8: 8330174: Protection zone for easier detection of accidental zero-nKlass use
  • f529bf7: 8350483: AArch64: turn on signum intrinsics by default on Ampere CPUs
  • 037e471: 8350666: cmp-baseline builds fail after JDK-8280682
  • c8a521f: 8345213: JVM Prefers /etc/timezone Over /etc/localtime on Debian 12
  • ... and 149 more: https://git.openjdk.org/jdk/compare/ed17c55ea34b3b6009dab11d64f21e0b7af3d701...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 26, 2025
@openjdk openjdk bot closed this Feb 26, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 26, 2025
@openjdk
Copy link

openjdk bot commented Feb 26, 2025

@mpdonova Pushed as commit 0f82268.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated security security-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

3 participants