JDK-8346465 : Add a check in setData() to restrict the update of Built-In ICC_Profiles

[honkar-jdk]

Built-in Profiles are singleton objects and if the user happens to modify this shared profile object via setData() then the modified version of the profile is returned each time the same built-in profile is requested via getInstance().

It is good to protect Built-in profiles from such direct modification by adding BuiltIn profile check in setData() such that only copies of Built-In profiles are allowed to be updated.

With the proposed fix, if Built-In profile is updated using .setData() it throws IAE - "BuiltIn profile cannot be modified"

There are no restrictions on creating copies of BuiltIn profile and then modifying it, but what is being restricted with this fix is - the direct modification of the shared BuiltIn profile instance.

Applications which need a modified version of the ICC Profile should instead do the following:

byte[] profileData = ICC_Profile.getData() // get the byte array representation of BuiltIn- profile
ICCProfile newProfile = ICC_Profile.getInstance(profileData) // create a new profile
newProfile.setData() // to modify and customize the profile

Following existing tests are modified to update a copy of Built-In profile.

• java/awt/color/ICC_Profile/SetHeaderInfo.java
• java/awt/color/ICC_ProfileSetNullDataTest.java
• sun/java2d/cmm/ProfileOp/SetDataTest.java

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change requires CSR request JDK-8350025 to be approved
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Warnings

 ⚠️ Patch contains a binary file (test/jdk/java/awt/color/ICC_Profile/BuiltInProfileCheck/builtIn.icc)
 ⚠️ Patch contains a binary file (test/jdk/java/awt/color/ICC_Profile/BuiltInProfileCheck/custom.icc)

Issues

• JDK-8346465: Add a check in setData() to restrict the update of Built-In ICC_Profiles (Bug - P3)
• JDK-8350025: Add a check in setData() to restrict the update of Built-In ICC_Profiles (CSR)

Reviewers

• Jayathirth D V (@jayathirthrao - Reviewer) Review applies to 52c76c73
• Alexey Ivanov (@aivanov-jdk - Reviewer)
• Phil Race (@prrace - Reviewer) Review applies to bc5e9755
• Sergey Bylokhov (@mrserb - Reviewer) Review applies to 71a125c6

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23606/head:pull/23606
$ git checkout pull/23606

Update a local copy of the PR:
$ git checkout pull/23606
$ git pull https://git.openjdk.org/jdk.git pull/23606/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23606

View PR using the GUI difftool:
$ git pr show -t 23606

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23606.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back honkar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@honkar-jdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8346465: Add a check in setData() to restrict the update of Built-In ICC_Profiles

Reviewed-by: aivanov, jdv, prr, serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

• af5db51: 8353641: Deprecate core library permission classes for removal
• 60f3d60: 8351110: ImageIO.write for JPEG can write corrupt JPEG for certain thumbnail dimensions
• dc249be: 8350462: MethodTypeForm.LF_INTERPRET can cache the MemberName instead
• ... and 17 more: https://git.openjdk.org/jdk/compare/45b7c748737f38c33c4666d17101b051b2fbe2ae...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@honkar-jdk The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 25: Full - Incremental (81917bd6)
• 24: Full - Incremental (6c8c105e)
• 23: Full - Incremental (b55bebf2)
• 22: Full - Incremental (47c0129e)
• 21: Full - Incremental (71a125c6)
• 20: Full - Incremental (0fe58a9a)
• 19: Full - Incremental (c32ed9b1)
• 18: Full - Incremental (7da4c5c7)
• 17: Full - Incremental (05d0783d)
• 16: Full - Incremental (bc5e9755)
• 15: Full - Incremental (afad8d3b)
• 14: Full - Incremental (d0b7b9f7)
• 13: Full - Incremental (918cd67a)
• 12: Full - Incremental (6e3b98ae)
• 11: Full - Incremental (a5754754)
• 10: Full - Incremental (b6fffacf)
• 09: Full - Incremental (483cda0f)
• 08: Full - Incremental (559fb749)
• 07: Full - Incremental (93e304f6)
• 06: Full - Incremental (32c8a13f)
• 05: Full - Incremental (977f468c)
• 04: Full - Incremental (8da82c10)
• 03: Full - Incremental (52c76c73)
• 02: Full - Incremental (1da22087)
• 01: Full - Incremental (11bdc2e3)
• 00: Full (0414f60c)

[honkar-jdk]

/csr needed

[openjdk]

@honkar-jdk has indicated that a compatibility and specification (CSR) request is needed for this pull request.

@honkar-jdk please create a CSR request for issue JDK-8346465 with the correct fix version. This pull request cannot be integrated until the CSR request is approved.

[honkar-jdk]

@aivanov-jdk As per our discussion I have updated the test code. Please re-review.

• Moved profile creation and testing into separate methods - prepareTestProfile(), testProfile()
• Added 2 more cases which tests reading .icc files that were serialized on older version of JDK.

@mrserb Can you please re-review the updated test.

[aivanov-jdk]

Looks good to me, yet there are a few small typos, fixes…

[honkar-jdk]

/integrate

[openjdk]

Going to push as commit 3131dd1.
Since your change was applied there have been 20 commits pushed to the master branch:

• af5db51: 8353641: Deprecate core library permission classes for removal
• 60f3d60: 8351110: ImageIO.write for JPEG can write corrupt JPEG for certain thumbnail dimensions
• dc249be: 8350462: MethodTypeForm.LF_INTERPRET can cache the MemberName instead
• ... and 17 more: https://git.openjdk.org/jdk/compare/45b7c748737f38c33c4666d17101b051b2fbe2ae...master

Your commit was automatically rebased without conflicts.

[openjdk]

@honkar-jdk Pushed as commit 3131dd1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.