8349977: JVMCIRuntime::_shared_library_javavm_id should be jlong

[dougxc]

The JVMCIRuntime::_shared_library_javavm_id field is initialized from a jlong in libgraal and so it's C++ type in HotSpot should match.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8349977: JVMCIRuntime::_shared_library_javavm_id should be jlong (Bug - P4)

Reviewers

• Yudi Zheng (@mur47x111 - Committer)
• Tom Rodriguez (@tkrodriguez - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23610/head:pull/23610
$ git checkout pull/23610

Update a local copy of the PR:
$ git checkout pull/23610
$ git pull https://git.openjdk.org/jdk.git pull/23610/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23610

View PR using the GUI difftool:
$ git pr show -t 23610

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23610.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dnsimon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dougxc This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8349977: JVMCIRuntime::_shared_library_javavm_id should be jlong

Reviewed-by: yzheng, never

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

• 6ddbcc3: 8328119: Support HKDF in SunPKCS11 (Preview)
• 28e744d: 8348092: Shenandoah: assert(nk >= _lowest_valid_narrow_klass_id && nk <= _highest_valid_narrow_klass_id) failed: narrowKlass ID out of range (3131947710)
• 0b50e47: 8349753: Incorrect use of CodeBlob::is_buffer_blob() in few places
• 18958c6: 8349925: [REDO] Support static JDK in libfontmanager/freetypeScaler.c
• c2fc947: 8349378: Build splashscreen lib with SIZE optimization
• 5b75ff7: 8349907: jdk.tools.jlink.internal.plugins.ZipPlugin does not close the Deflater in exceptional cases
• add3cd1: 8348600: Update PipeWire to 1.3.81
• efc597b: 8349564: Clean warnings found in jpackage tests when building them with -Xlint:all
• 29202d1: 8349648: Test tools/jpackage/share/JLinkOptionsTest.java fails with --enable-linkable-runtime set after JDK-8346434
• 24b7f81: 8349783: g1RemSetSummary.cpp:344:68: runtime error: member call on null pointer of type 'struct G1HeapRegion'

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@dougxc The following labels will be automatically applied to this pull request:

• graal
• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (b7a38951)

[mur47x111]

LGTM

[dougxc]

Passes the openjdk-pr-canary: https://github.com/dougxc/openjdk-pr-canary/blob/master/tested-prs/23610/b7a38951a54ff4c1186a3682f717805822575ea8.json

[dougxc]

Thanks for the reviews.

/integrate

[openjdk]

Going to push as commit a88e2a5.
Since your change was applied there have been 11 commits pushed to the master branch:

• 2eac490: 8349868: Remove unneeded libjava shared library dependency from jtreg test libNewDirectByteBuffer, libDirectIO and libInheritedChannel
• 6ddbcc3: 8328119: Support HKDF in SunPKCS11 (Preview)
• 28e744d: 8348092: Shenandoah: assert(nk >= _lowest_valid_narrow_klass_id && nk <= _highest_valid_narrow_klass_id) failed: narrowKlass ID out of range (3131947710)
• 0b50e47: 8349753: Incorrect use of CodeBlob::is_buffer_blob() in few places
• 18958c6: 8349925: [REDO] Support static JDK in libfontmanager/freetypeScaler.c
• c2fc947: 8349378: Build splashscreen lib with SIZE optimization
• 5b75ff7: 8349907: jdk.tools.jlink.internal.plugins.ZipPlugin does not close the Deflater in exceptional cases
• add3cd1: 8348600: Update PipeWire to 1.3.81
• efc597b: 8349564: Clean warnings found in jpackage tests when building them with -Xlint:all
• 29202d1: 8349648: Test tools/jpackage/share/JLinkOptionsTest.java fails with --enable-linkable-runtime set after JDK-8346434
• ... and 1 more: https://git.openjdk.org/jdk/compare/a637ccf2fead25ea6a06ad6bd65e92b8694ee11c...master

Your commit was automatically rebased without conflicts.

[openjdk]

@dougxc Pushed as commit a88e2a5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.