8285624: jpackage fails to create exe, msi when Windows OS is in FIPS mode

[alexeysemenyukoracle]

Make jpackage capable of using wix3 when Federal Information Processing Standard (FIPS) mode is enabled on Windows.

When FIPS mode is enabled, running candle.exe -? prints:

candle.exe : error CNDL0308 : The Federal Information Processing Standard (FIPS) appears to be enabled on the machine. You must either disable FIPS or use FIPS-compliant security algorithms to generate IDs by passing the -fips command-line switch or by setting <FipsCompliant>true</FipsCompliant> in your .wixproj project.

Though jpackage expects the following output:

Microsoft (R) Windows Installer Xml Compiler version 3.5.2519.0
Copyright (C) Microsoft Corporation. All rights reserved.

 usage:  candle.exe [-?] [-nologo] [-out outputFile] sourceFile [sourceFile ...] [@responseFile]

 ...

candle.exe also exits with an error code (308).

To workaround the problem, run candle.exe -fips to make it print standard help output regardless FIPS mode enable/disable.

Run candle.exe the second time to detect if it requires an -fips command line switch. If it does, jpackage will add it automatically.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Warning

 ⚠️ Found leading lowercase letter in issue title for 8285624: jpackage fails to create exe, msi when Windows OS is in FIPS mode

Issue

• JDK-8285624: jpackage fails to create exe, msi when Windows OS is in FIPS mode (Bug - P4)

Reviewers

• Alexander Matveev (@sashamatveev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23612/head:pull/23612
$ git checkout pull/23612

Update a local copy of the PR:
$ git checkout pull/23612
$ git pull https://git.openjdk.org/jdk.git pull/23612/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23612

View PR using the GUI difftool:
$ git pr show -t 23612

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23612.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@alexeysemenyukoracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8285624: jpackage fails to create exe, msi when Windows OS is in FIPS mode

Reviewed-by: almatvee

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

• 3e7acfa: 8349873: StackOverflowError after JDK-8342550 if -Duser.timezone= is set to a deprecated zone id
• d8fcd43: 8349927: Waiting for compiler termination delays shutdown for 10+ ms
• a88e2a5: 8349977: JVMCIRuntime::_shared_library_javavm_id should be jlong
• 2eac490: 8349868: Remove unneeded libjava shared library dependency from jtreg test libNewDirectByteBuffer, libDirectIO and libInheritedChannel
• 6ddbcc3: 8328119: Support HKDF in SunPKCS11 (Preview)
• 28e744d: 8348092: Shenandoah: assert(nk >= _lowest_valid_narrow_klass_id && nk <= _highest_valid_narrow_klass_id) failed: narrowKlass ID out of range (3131947710)
• 0b50e47: 8349753: Incorrect use of CodeBlob::is_buffer_blob() in few places
• 18958c6: 8349925: [REDO] Support static JDK in libfontmanager/freetypeScaler.c
• c2fc947: 8349378: Build splashscreen lib with SIZE optimization
• 5b75ff7: 8349907: jdk.tools.jlink.internal.plugins.ZipPlugin does not close the Deflater in exceptional cases
• ... and 1 more: https://git.openjdk.org/jdk/compare/efc597bf47bff46596bb29b03b5750bfc5afe851...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@alexeysemenyukoracle The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (c14f5ffb)

[alexeysemenyukoracle]

@sashamatveev PTAL

[sashamatveev]

Looks good.

[alexeysemenyukoracle]

/integrate

[openjdk]

Going to push as commit ff52859.
Since your change was applied there have been 12 commits pushed to the master branch:

• 3741c98: 8349883: Locale.LanguageRange.parse("-") throws ArrayIndexOutOfBoundsException
• 3e7acfa: 8349873: StackOverflowError after JDK-8342550 if -Duser.timezone= is set to a deprecated zone id
• d8fcd43: 8349927: Waiting for compiler termination delays shutdown for 10+ ms
• a88e2a5: 8349977: JVMCIRuntime::_shared_library_javavm_id should be jlong
• 2eac490: 8349868: Remove unneeded libjava shared library dependency from jtreg test libNewDirectByteBuffer, libDirectIO and libInheritedChannel
• 6ddbcc3: 8328119: Support HKDF in SunPKCS11 (Preview)
• 28e744d: 8348092: Shenandoah: assert(nk >= _lowest_valid_narrow_klass_id && nk <= _highest_valid_narrow_klass_id) failed: narrowKlass ID out of range (3131947710)
• 0b50e47: 8349753: Incorrect use of CodeBlob::is_buffer_blob() in few places
• 18958c6: 8349925: [REDO] Support static JDK in libfontmanager/freetypeScaler.c
• c2fc947: 8349378: Build splashscreen lib with SIZE optimization
• ... and 2 more: https://git.openjdk.org/jdk/compare/efc597bf47bff46596bb29b03b5750bfc5afe851...master

Your commit was automatically rebased without conflicts.

[openjdk]

@alexeysemenyukoracle Pushed as commit ff52859.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.