8349908: RISC-V: C2 SelectFromTwoVector

[Hamlin-Li]

Hi,
Can you help to review the patch?
This optimization is mainly for the vector API.

Thanks

Test

jtreg

test/jdk/jdk/incubator/vector/

Performance

run on bananapi

master vs patch

Benchmark	(size)	Mode	Cnt	Score -master	Error - master	Score - patch	Error - patch	Units	Improvement (master / patch)
SelectFromBenchmark.selectFromByteVector	1024	avgt	10	26422.495	674.565	721.604	1.036	ns/op	36.616
SelectFromBenchmark.selectFromByteVector	2048	avgt	10	53964.411	1751.618	1385.24	0.956	ns/op	38.957
SelectFromBenchmark.selectFromDoubleVector	1024	avgt	10	218430.616	1369.409	7739.774	14.408	ns/op	28.222
SelectFromBenchmark.selectFromDoubleVector	2048	avgt	10	387889.456	7889.791	16197.77	66.775	ns/op	23.947
SelectFromBenchmark.selectFromFloatVector	1024	avgt	10	103483.717	492.525	3580.358	29.127	ns/op	28.903
SelectFromBenchmark.selectFromFloatVector	2048	avgt	10	226125.02	3118.836	7797.025	4.346	ns/op	29.001
SelectFromBenchmark.selectFromIntVector	1024	avgt	10	97007.999	2607.711	2898.38	0.833	ns/op	33.47
SelectFromBenchmark.selectFromIntVector	2048	avgt	10	222303.308	3096.615	6398.214	30.345	ns/op	34.745
SelectFromBenchmark.selectFromLongVector	1024	avgt	10	245033.436	1652.527	6307.773	24.597	ns/op	38.846
SelectFromBenchmark.selectFromLongVector	2048	avgt	10	438503.547	5972.265	17215.996	167.442	ns/op	25.471
SelectFromBenchmark.selectFromShortVector	1024	avgt	10	53632.502	2159.433	1418.215	2.953	ns/op	37.817
SelectFromBenchmark.selectFromShortVector	2048	avgt	10	111764.327	1220.509	3061.386	14.716	ns/op	36.508

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8349908: RISC-V: C2 SelectFromTwoVector (Enhancement - P4)

Reviewers

• Fei Yang (@RealFYang - Reviewer)
• Ludovic Henry (@luhenry - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23614/head:pull/23614
$ git checkout pull/23614

Update a local copy of the PR:
$ git checkout pull/23614
$ git pull https://git.openjdk.org/jdk.git pull/23614/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23614

View PR using the GUI difftool:
$ git pr show -t 23614

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23614.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@Hamlin-Li This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8349908: RISC-V: C2 SelectFromTwoVector

Reviewed-by: fyang, luhenry

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 81 new commits pushed to the master branch:

• d7baae3: 8350178: Incorrect comment after JDK-8345580
• 160db5f: 8340110: Ubsan: verifier.cpp:2043:19: runtime error: shift exponent 100 is too large for 32-bit type 'int'
• ff05d97: 8349180: Remove redundant initialization in ciField constructor
• 013fda1: 8348172: C2: Remove unused local variables in filter_helper() methods
• 3353f8e: 8349652: Rewire nmethod oop load barriers
• 8df8040: 8350093: RISC-V: java/math/BigInteger/LargeValueExceptions.java timeout with COH
• 8ec5893: 8346781: [JVMCI] Limit ServiceLoader to class initializers
• 3f0c137: 8347123: Add missing @serial tags to other modules
• 8b2aa51: 8349780: AIX os::get_summary_cpu_info support Power 11
• 650d0d9: 8348865: JButton/bug4796987.java never runs because Windows XP is unavailable
• ... and 71 more: https://git.openjdk.org/jdk/compare/41bdc47d71340e5d7f4317a5040521868d4c4314...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@Hamlin-Li The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (086e3023)
• 01: Full - Incremental (e8b29c62)
• 00: Full (a28926b6)

[RealFYang]

Seems fine. I have two minor questions. Thanks.

[RealFYang]

LGTM. Thanks for the update.

[Hamlin-Li]

LGTM. Thanks for the update.

Thanks!

[Hamlin-Li]

/integrate

[openjdk]

Going to push as commit 885be2e.
Since your change was applied there have been 82 commits pushed to the master branch:

• 8193e0d: 8346280: C2: implement late barrier elision for G1
• d7baae3: 8350178: Incorrect comment after JDK-8345580
• 160db5f: 8340110: Ubsan: verifier.cpp:2043:19: runtime error: shift exponent 100 is too large for 32-bit type 'int'
• ff05d97: 8349180: Remove redundant initialization in ciField constructor
• 013fda1: 8348172: C2: Remove unused local variables in filter_helper() methods
• 3353f8e: 8349652: Rewire nmethod oop load barriers
• 8df8040: 8350093: RISC-V: java/math/BigInteger/LargeValueExceptions.java timeout with COH
• 8ec5893: 8346781: [JVMCI] Limit ServiceLoader to class initializers
• 3f0c137: 8347123: Add missing @serial tags to other modules
• 8b2aa51: 8349780: AIX os::get_summary_cpu_info support Power 11
• ... and 72 more: https://git.openjdk.org/jdk/compare/41bdc47d71340e5d7f4317a5040521868d4c4314...master

Your commit was automatically rebased without conflicts.

[openjdk]

@Hamlin-Li Pushed as commit 885be2e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.