8349180: Remove redundant initialization in ciField constructor

[marc-chevalier]

In ciField's ctor, _name is initialized twice. I think we can indeed apply the suggested fix and remove the second assignment. _name is set correctly the first time (and without the useless cast), and not modified in between.

Thanks,
Marc

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8349180: Remove redundant initialization in ciField constructor (Enhancement - P4)

Reviewers

• Christian Hagedorn (@chhagedorn - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23637/head:pull/23637
$ git checkout pull/23637

Update a local copy of the PR:
$ git checkout pull/23637
$ git pull https://git.openjdk.org/jdk.git pull/23637/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23637

View PR using the GUI difftool:
$ git pr show -t 23637

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23637.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

Hi @marc-chevalier, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user marc-chevalier" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

[openjdk]

@marc-chevalier This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8349180: Remove redundant initialization in ciField constructor

Reviewed-by: chagedorn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 29 new commits pushed to the master branch:

• 013fda1: 8348172: C2: Remove unused local variables in filter_helper() methods
• 3353f8e: 8349652: Rewire nmethod oop load barriers
• 8df8040: 8350093: RISC-V: java/math/BigInteger/LargeValueExceptions.java timeout with COH
• 8ec5893: 8346781: [JVMCI] Limit ServiceLoader to class initializers
• 3f0c137: 8347123: Add missing @serial tags to other modules
• 8b2aa51: 8349780: AIX os::get_summary_cpu_info support Power 11
• 650d0d9: 8348865: JButton/bug4796987.java never runs because Windows XP is unavailable
• 906358d: 8294155: Exception thrown before awaitAndCheck hangs PassFailJFrame
• 2bd8f02: 8342524: Use latch in AbstractButton/bug6298940.java instead of delay
• 7f3ecb4: 8346664: C2: Optimize mask check with constant offset
• ... and 19 more: https://git.openjdk.org/jdk/compare/57f4c30fb6be1da57c8fcc742b5c36d842eef397...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@chhagedorn) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@marc-chevalier The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[marc-chevalier]

/covered

[bridgekeeper]

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

[gustavosimon]

Hello @marc-chevalier! I have already open a PR for this matter. PR is #23480.

[mlbridge]

Webrevs

• 00: Full (1f37759c)

[chhagedorn]

Hello @marc-chevalier! I have already open a PR for this matter. PR is #23480.

Hi @gustavosimon, the JBS issue was already assigned to @marc-chevalier. If you intend to work on an issue, please check the following:

• The issue is already assigned in JBS?
  • Reach out to the assignee and ask if the person is currently working on the issue or has intentions to do so. If not, they can reassign it to you or someone else on your behalf (if you don't have a JBS account).
• The issue is unassigned in JBS?
  • Assign the issue to yourself.
  • If you don't have a JBS account: Reach out to someone who can assign it to him/herself on your behalf.

This avoids "stealing" work that was in progress or planned to do later or even worse doing completely duplicated work which is unfortunate.

[chhagedorn]

Looks good and trivial.

[marc-chevalier]

Thanks Christian!

/integrate

[openjdk]

@marc-chevalier
Your change (at version 1f37759) is now ready to be sponsored by a Committer.

[chhagedorn]

/sponsor

[openjdk]

Going to push as commit ff05d97.
Since your change was applied there have been 29 commits pushed to the master branch:

• 013fda1: 8348172: C2: Remove unused local variables in filter_helper() methods
• 3353f8e: 8349652: Rewire nmethod oop load barriers
• 8df8040: 8350093: RISC-V: java/math/BigInteger/LargeValueExceptions.java timeout with COH
• 8ec5893: 8346781: [JVMCI] Limit ServiceLoader to class initializers
• 3f0c137: 8347123: Add missing @serial tags to other modules
• 8b2aa51: 8349780: AIX os::get_summary_cpu_info support Power 11
• 650d0d9: 8348865: JButton/bug4796987.java never runs because Windows XP is unavailable
• 906358d: 8294155: Exception thrown before awaitAndCheck hangs PassFailJFrame
• 2bd8f02: 8342524: Use latch in AbstractButton/bug6298940.java instead of delay
• 7f3ecb4: 8346664: C2: Optimize mask check with constant offset
• ... and 19 more: https://git.openjdk.org/jdk/compare/57f4c30fb6be1da57c8fcc742b5c36d842eef397...master

Your commit was automatically rebased without conflicts.

[openjdk]

@chhagedorn @marc-chevalier Pushed as commit ff05d97.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[gustavosimon]

@chhagedorn Got it. Actually, when I started working on this, the issue was unassigned.
I will ask to @RealCLanger to assign it to me next times.

Can you review my OCA verification?

[chhagedorn]

@chhagedorn Got it. Actually, when I started working on this, the issue was unassigned.

Oh, I see - looks like an unfortunate timing!

I will ask to @RealCLanger to assign it to me next times.

Sounds good :-)

Can you review my OCA verification?

We pinged @robilad to review it.

[gustavosimon]

@chhagedorn Thanks! Looking forward!

[gustavosimon]

Hello @chhagedorn! Any luck about this matter?

[robilad]

Please send me an e-mail at Dalibor.Topic@oracle.com so that I can verify your account's OCA.