8258799 : [Testbug] RandomCommandsTest must check if tested directive is added via jcmd

[neliasso]

RandomCommandsTest.java is checking a mix of valid and invalid compilecommands and compiler directives. When they fail they have different behaviour:

A compilecommand that is malformed will result in a printed error, and then the VM continues.
A compiler directive that is malformed, that is added via commandline, will abort the VM, much like any other VM-flag would.
A compiler directive that is malformed, that is added via jcmd will print an error, and the VM continues - just like with any other jcmd.

The RandomCommandsTest fails when generating a malformed compiler directive and adding it via jcmd - because it expects the VM to abort.

This patch fixes that.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8258799: [Testbug] RandomCommandsTest must check if tested directive is added via jcmd

Reviewers

• Vladimir Kozlov (@vnkozlov - Reviewer)
• Igor Ignatyev (@iignatev - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2364/head:pull/2364
$ git checkout pull/2364

[bridgekeeper]

👋 Welcome back neliasso! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@neliasso The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (a0a5737)

[vnkozlov]

Looks good.

[openjdk]

@neliasso This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8258799: [Testbug] RandomCommandsTest must check if tested directive is added via jcmd

Reviewed-by: kvn, iignatyev

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

• 9af3339: 8261003: Bad Copyright header format after JDK-8183372
• 6dc3c6d: 8183372: Refactor java/lang/Class shell tests to java
• 105d3e8: 8260861: TrustStoreDescriptor log the same value
• 69189f8: 8256421: Add 2 HARICA roots to cacerts truststore
• f546fd0: 8260902: CDS mapping errors should not lead to unconditional output
• d7b1fc5: 8260707: java/lang/instrument/PremainClass/InheritAgent0100.java times out
• 0093183: 8260368: [PPC64] GC interface needs enhancement to support GCs with load barriers
• defcb04: 8260867: ProblemList java/awt/FullScreen/TranslucentWindow/TranslucentWindow.java on linux
• a421bfa: 8259839: SystemDictionary exports too much implementation
• 189b65b: 8260264: Move common os_ inline methods to a common posix source file
• ... and 9 more: https://git.openjdk.java.net/jdk/compare/50f9a70f0d4c8ec005d860070261215d7c319e2e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[neliasso]

Thank you Igor and Vladimir!

[neliasso]

/integrate

[openjdk]

@neliasso Since your change was applied there have been 34 commits pushed to the master branch:

• b0ee7a8: 8241995: Clarify InetSocketAddress::toString specification
• 0ef93fe: 8259265: Refactor UncaughtExceptions shell test as java test.
• 5324b5c: 8260998: Shenandoah: Restore reference processing statistics reporting
• c8de943: 8260617: Merge ZipFile encoding check with the initial hash calculation
• ae2c5f0: 8260581: IGV: enhance node search
• 9037615: 8222850: jshell tool: Misleading cascade compiler error in switch expression with undefined vars
• 91e6c75: 8260928: InitArrayShortSize constraint func should print a helpful error message
• cb127a4: 8198343: Test java/awt/print/PrinterJob/TestPgfmtSetMPA.java may fail w/o printer
• c008410: 8197825: [Test] Intermittent timeout with javax/swing JColorChooser Test
• b9d4211: 8260193: Remove JVM_GetInterfaceVersion() and JVM_DTraceXXX
• ... and 24 more: https://git.openjdk.java.net/jdk/compare/50f9a70f0d4c8ec005d860070261215d7c319e2e...master

Your commit was automatically rebased without conflicts.

Pushed as commit 472bf62.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.