Skip to content

8350111: [PPC] AsyncGetCallTrace crashes when called while handling SIGTRAP #23641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
reinrich wants to merge 4 commits into from
Closed

8350111: [PPC] AsyncGetCallTrace crashes when called while handling SIGTRAP #23641

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c4b81e2
Handle attempt to sample stack while handling SIGTRAP
reinrich Feb 14, 2025
17d8032
Revert first fix
reinrich Feb 26, 2025
9a2eedc
A frame isn't safe_for_sender if sender_pc() returns null
reinrich Feb 26, 2025
92b0ef9
Improve whitespace
reinrich Feb 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/hotspot/cpu/ppc/frame_ppc.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/*
* Copyright (c) 2000, 2025, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2012, 2024 SAP SE. All rights reserved.
* Copyright (c) 2012, 2025 SAP SE. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand Down Expand Up @@ -195,6 +195,15 @@ bool frame::safe_for_sender(JavaThread *thread) {
return false;
}

if (sender_pc() == nullptr) {
// Likely the return pc was not yet stored to stack. We rather discard this
// sample also because we would hit an assertion in frame::setup(). We can
// find any other random value if the return pc was not yet stored to
// stack. We rely on consistency checks to handle this (see
// e.g. find_initial_Java_frame())
return false;
}

return true;
}

Expand Down