Skip to content

Conversation

@bradfordwetmore
Copy link
Contributor

@bradfordwetmore bradfordwetmore commented Feb 15, 2025

The example code in the JEP was much clearer than that in the current KEM class. It's easier to keep the various nested classes straight, rather than using vars which require scrolling to see what the return types are.

Added/tweaked example for clarity.

Generated/checked javadocs, but no regression/JCK tests is necessary.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8350147: Replace example in KEM class with the one from JEP 452 (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23652/head:pull/23652
$ git checkout pull/23652

Update a local copy of the PR:
$ git checkout pull/23652
$ git pull https://git.openjdk.org/jdk.git pull/23652/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23652

View PR using the GUI difftool:
$ git pr show -t 23652

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23652.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 15, 2025

👋 Welcome back wetmore! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 15, 2025

@bradfordwetmore This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8350147: Replace example in KEM class with the one from JEP 452

Reviewed-by: weijun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 5cf1132: 8350098: jpackage test lib erroneously will run methods without @test annotation as tests
  • 6234536: 8349915: CTW: Lots of level 3 compiles are done at level 2 after JDK-8348570

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 15, 2025
@openjdk
Copy link

openjdk bot commented Feb 15, 2025

@bradfordwetmore The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Feb 15, 2025
@mlbridge
Copy link

mlbridge bot commented Feb 15, 2025

Webrevs

Copy link
Contributor

@wangweij wangweij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@bradfordwetmore
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 15, 2025
@openjdk
Copy link

openjdk bot commented Feb 15, 2025

Going to push as commit 7d11418.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 5cf1132: 8350098: jpackage test lib erroneously will run methods without @test annotation as tests
  • 6234536: 8349915: CTW: Lots of level 3 compiles are done at level 2 after JDK-8348570

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 15, 2025
@openjdk openjdk bot closed this Feb 15, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 15, 2025
@openjdk
Copy link

openjdk bot commented Feb 15, 2025

@bradfordwetmore Pushed as commit 7d11418.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Copy link
Member

@seanjmullan seanjmullan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed this after you already integrated and noticed the typo.

* <p>
*
* Example:
* Example operation using a ficticious {@code KEM} algorithm {@code ABC}:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: s/ficticious/fictitious/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix in JDK-8350476

@bradfordwetmore bradfordwetmore deleted the JDK-8350147 branch March 6, 2025 21:33
@bradfordwetmore bradfordwetmore restored the JDK-8350147 branch March 6, 2025 21:34
@bradfordwetmore bradfordwetmore deleted the JDK-8350147 branch March 6, 2025 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated security security-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

3 participants