Skip to content

8349721: Add aarch64 intrinsics for ML-KEM #23663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 14 commits into from
Closed

8349721: Add aarch64 intrinsics for ML-KEM #23663

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
a3c461f
kyber aarch64 intrinsics
ferakocz Jan 10, 2025
7951fe3
removing trailing spaces
ferakocz Feb 17, 2025
ff0f843
Merged master
ferakocz Feb 28, 2025
4adc5cf
A little cleanup
ferakocz Feb 28, 2025
0910238
Merged master.
ferakocz Mar 4, 2025
7e9b3d8
Fixed mismerge.
ferakocz Mar 4, 2025
9ec9a6c
Fixed bad assertion.
ferakocz Mar 22, 2025
8d5a9e1
Merged master.
ferakocz Mar 23, 2025
11593cb
Changes suggested by Andrew Dinn.
ferakocz Apr 10, 2025
74ff3d9
Code rearrange, some renaming, fixing comments
ferakocz Apr 10, 2025
d7f7fc8
Clarified comments as suggested by Andrew Dinn
ferakocz Apr 14, 2025
5901547
Uncommented an accidentakky commented line in ML_KEM.java + changed 1…
ferakocz Apr 14, 2025
b6b3155
Accepted more comment changes from Andrew Dinn.
ferakocz Apr 15, 2025
3c3bca6
Fixed asserts.
ferakocz Apr 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/java.base/share/classes/com/sun/crypto/provider/ML_KEM.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1033,7 +1033,7 @@ static void implKyberInverseNttJava(short[] poly) {
// Works in place, but also returns its (modified) input so that it can
// be used in expressions
private short[] mlKemInverseNTT(short[] poly) {
assert(poly.length == ML_KEM_N);
assert poly.length == ML_KEM_N;
implKyberInverseNtt(poly, montZetasForVectorInverseNttArr);
return poly;
}
Expand Down Expand Up @@ -1151,8 +1151,8 @@ static void implKyberNttMultJava(short[] result, short[] ntta, short[] nttb) {
// The result is a representation of the product still in the NTT domain.
// The coefficients in the result are in the range (-mlKem_q, mlKem_q).
private void nttMult(short[] result, short[] ntta, short[] nttb) {
assert (result.length == ML_KEM_N) && (ntta.length == ML_KEM_N &&
(nttb.length == ML_KEM_N));
assert (result.length == ML_KEM_N) && (ntta.length == ML_KEM_N) &&
(nttb.length == ML_KEM_N);
implKyberNttMult(result, ntta, nttb, montZetasForVectorNttMultArr);
}

Expand Down Expand Up @@ -1368,8 +1368,8 @@ private void twelve2Sixteen(byte[] condensed, int index,
if (remainder != 0) {
i++;
}
assert (((remainder != 0) && (remainder != 48)) ||
index + i * 96 > condensed.length);
assert ((remainder == 0) || (remainder == 48)) &&
(index + i * 96 <= condensed.length);
implKyber12To16(condensed, index, parsed, parsedLength);
}

Expand Down