Skip to content

8349721: Add aarch64 intrinsics for ML-KEM #23663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 14 commits into from
Closed

8349721: Add aarch64 intrinsics for ML-KEM #23663

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
a3c461f
kyber aarch64 intrinsics
ferakocz Jan 10, 2025
7951fe3
removing trailing spaces
ferakocz Feb 17, 2025
ff0f843
Merged master
ferakocz Feb 28, 2025
4adc5cf
A little cleanup
ferakocz Feb 28, 2025
0910238
Merged master.
ferakocz Mar 4, 2025
7e9b3d8
Fixed mismerge.
ferakocz Mar 4, 2025
9ec9a6c
Fixed bad assertion.
ferakocz Mar 22, 2025
8d5a9e1
Merged master.
ferakocz Mar 23, 2025
11593cb
Changes suggested by Andrew Dinn.
ferakocz Apr 10, 2025
74ff3d9
Code rearrange, some renaming, fixing comments
ferakocz Apr 10, 2025
d7f7fc8
Clarified comments as suggested by Andrew Dinn
ferakocz Apr 14, 2025
5901547
Uncommented an accidentakky commented line in ML_KEM.java + changed 1…
ferakocz Apr 14, 2025
b6b3155
Accepted more comment changes from Andrew Dinn.
ferakocz Apr 15, 2025
3c3bca6
Fixed asserts.
ferakocz Apr 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/hotspot/cpu/aarch64/vm_version_aarch64.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -694,7 +694,6 @@ void VM_Version::print_platform_virtualization_info(outputStream* st) {
void VM_Version::initialize_cpu_information(void) {
// do nothing if cpu info has been initialized
if (_initialized) {
fprintf(stderr, "_features_string = \"%s\"", _features_string);
return;
}

Expand Down
22 changes: 0 additions & 22 deletions src/hotspot/share/opto/library_call.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,28 +233,6 @@ bool LibraryCallKit::try_to_inline(int predicate) {
}
assert(merged_memory(), "");

if(intrinsic_id() == vmIntrinsics::_digestBase_implCompressMB) {
fprintf(stderr, "try_to_inline call for _digestBase_implCompressMB\n");
} else if(intrinsic_id() == vmIntrinsics::_sha3_implCompress) {
fprintf(stderr, "try_to_inline call for _sha3_implCompress\n");
} else if(intrinsic_id() == vmIntrinsics::_double_keccak) {
fprintf(stderr, "try_to_inline call for _double_keccak\n");
} else if(intrinsic_id() == vmIntrinsics::_kyberNtt) {
fprintf(stderr, "try_to_inline call for _kyberNtt\n");
} else if(intrinsic_id() == vmIntrinsics::_kyberInverseNtt) {
fprintf(stderr, "try_to_inline call for _kyberInverseNtt\n");
} else if(intrinsic_id() == vmIntrinsics::_kyberNttMult) {
fprintf(stderr, "try_to_inline call for _kyberNttMult\n");
} else if(intrinsic_id() == vmIntrinsics::_kyberAddPoly_2) {
fprintf(stderr, "try_to_inline call for _kyberAddPoly_2\n");
} else if(intrinsic_id() == vmIntrinsics::_kyberAddPoly_3) {
fprintf(stderr, "try_to_inline call for _kyberAddPoly_3\n");
} else if(intrinsic_id() == vmIntrinsics::_kyber12To16) {
fprintf(stderr, "try_to_inline call for _kyber12To16\n");
} else if(intrinsic_id() == vmIntrinsics::_kyberBarrettReduce) {
fprintf(stderr, "try_to_inline call for _kyberBarrettReduce\n");
}

switch (intrinsic_id()) {
case vmIntrinsics::_hashCode: return inline_native_hashcode(intrinsic()->is_virtual(), !is_static);
case vmIntrinsics::_identityHashCode: return inline_native_hashcode(/*!virtual*/ false, is_static);
Expand Down
2 changes: 1 addition & 1 deletion src/java.base/share/classes/com/sun/crypto/provider/ML_KEM.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -649,7 +649,7 @@ private K_PKE_KeyPair generateK_PkeKeyPair(byte[] seed) {
}

mlKemG.update(seed);
// mlKemG.update((byte)mlKem_k);
mlKemG.update((byte)mlKem_k);

var rhoSigma = mlKemG.digest();
var rho = Arrays.copyOfRange(rhoSigma, 0, 32);
Expand Down