Skip to content

8349547: Document jlink and jmods Supported Usage#23672

Closed
pkumaraswamy wants to merge 1 commit intoopenjdk:masterfrom
pkumaraswamy:JDK-8349547
Closed

8349547: Document jlink and jmods Supported Usage#23672
pkumaraswamy wants to merge 1 commit intoopenjdk:masterfrom
pkumaraswamy:JDK-8349547

Conversation

@pkumaraswamy
Copy link
Contributor

@pkumaraswamy pkumaraswamy commented Feb 18, 2025

Document supported usage of jlink with JDK jmod's
The document will reflect the future work from JDK-8347831


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8349547: Document jlink and jmods Supported Usage (Task - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23672/head:pull/23672
$ git checkout pull/23672

Update a local copy of the PR:
$ git checkout pull/23672
$ git pull https://git.openjdk.org/jdk.git pull/23672/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23672

View PR using the GUI difftool:
$ git pr show -t 23672

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23672.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 18, 2025

👋 Welcome back pkumaraswamy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 18, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 18, 2025
@openjdk
Copy link

openjdk bot commented Feb 18, 2025

@pkumaraswamy The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Feb 18, 2025
@mlbridge
Copy link

mlbridge bot commented Feb 18, 2025

Webrevs

@AlanBateman
Copy link
Contributor

There are several issues with the proposed update. I think it would be better to close this PR and we'll update the jlink docs when a solution for JDK-8347831 is proposed.

@pkumaraswamy
Copy link
Contributor Author

pkumaraswamy commented Feb 20, 2025

Closing out this PR, since documentation will be handled in JDK-8347831

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants