8350211: CTW: Attempt to preload all classes in constant pool

[shipilev]

CTW runners do preloading for constant pools ahead of time. I believe this is done to expose more loaded classes to the compilations, so to extend the compilation scope.

Unfortunately, current code catches the first exception when loading the constant pool and stops preloading. This routinely happens when CTW runner processes a 3rd party JAR, where dependencies might normally be in other JARs.

I believe we should attempt to resolve all constant pool entries when preloading is requested. This would likely expand the scope of CTW testing.

Additional testing:

• Linux x86_64 server fastdebug, applications/ctw/modules still passes

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8350211: CTW: Attempt to preload all classes in constant pool (Enhancement - P4)

Reviewers

• Vladimir Ivanov (@iwanowww - Reviewer)
• Christian Hagedorn (@chhagedorn - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23673/head:pull/23673
$ git checkout pull/23673

Update a local copy of the PR:
$ git checkout pull/23673
$ git pull https://git.openjdk.org/jdk.git pull/23673/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23673

View PR using the GUI difftool:
$ git pr show -t 23673

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23673.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8350211: CTW: Attempt to preload all classes in constant pool

Reviewed-by: vlivanov, chagedorn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

• 0ef1c40: 8350006: IGV: show memory slices as type information
• 9042aa8: 8339238: Update to use jtreg 7.5.1
• 4de92a4: 8350224: Test javax/swing/JComboBox/TestComboBoxComponentRendering.java fails in ubuntu 23.x and later
• 04659a4: 8350197: [UBSAN] Node::dump_idx reported float-cast-overflow
• 2d03bd0: 8350280: The JDK-8346050 testlibrary changes break the build
• f2b4e12: 8350263: JvmciNotifyBootstrapFinishedEventTest intermittently times out
• 46d4a60: 8349088: De-virtualize Codeblob and nmethod
• 62d93f2: 8346050: Update BuildTestLib.gmk to build whole testlibrary
• e1d0a9c: 8350202: Tune for Power10 CPUs on Linux ppc64le
• 885be2e: 8349908: RISC-V: C2 SelectFromTwoVector
• ... and 8 more: https://git.openjdk.org/jdk/compare/3f0c1370269db978072814c2170fc3987efade85...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@shipilev The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (eb506106)

[iwanowww]

Nice finding, Aleksey. Looks good.

[shipilev]

Need another Reviewer here; maybe @vnkozlov, @chhagedorn, @TobiHartmann?

[chhagedorn]

Looks good to me, too!

[shipilev]

Thank you!

/integrate

[openjdk]

Going to push as commit d13fd57.
Since your change was applied there have been 18 commits pushed to the master branch:

• 0ef1c40: 8350006: IGV: show memory slices as type information
• 9042aa8: 8339238: Update to use jtreg 7.5.1
• 4de92a4: 8350224: Test javax/swing/JComboBox/TestComboBoxComponentRendering.java fails in ubuntu 23.x and later
• 04659a4: 8350197: [UBSAN] Node::dump_idx reported float-cast-overflow
• 2d03bd0: 8350280: The JDK-8346050 testlibrary changes break the build
• f2b4e12: 8350263: JvmciNotifyBootstrapFinishedEventTest intermittently times out
• 46d4a60: 8349088: De-virtualize Codeblob and nmethod
• 62d93f2: 8346050: Update BuildTestLib.gmk to build whole testlibrary
• e1d0a9c: 8350202: Tune for Power10 CPUs on Linux ppc64le
• 885be2e: 8349908: RISC-V: C2 SelectFromTwoVector
• ... and 8 more: https://git.openjdk.org/jdk/compare/3f0c1370269db978072814c2170fc3987efade85...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit d13fd57.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.