8350260: Improve HTML instruction formatting in PassFailJFrame

[aivanov-jdk]

Problem:

When instructions are long, the formatting in PassFailJFrame looks off:

1. When the instructions are displayed on the screen for the first time, the HTML is scrolled to the bottom, which isn't convenient;
2. Numbers above 10 in the list are clipped on the left;
3. No border around the HTML text.

These problems were found while converting the instructions for test/jdk/javax/accessibility/TestJCheckBoxToggleAccessibility.java in #23436.

Screenshots of the instructions

The instructions are scrolled to the bottom when the test starts:

The number 10 in the list is clipped on the left:

The headings “Testing with…” are flushed to the left, there's no additional space between the scroll pane border and the text.

Fix:

1. Adjust the list margins to accommodate for longer text;
2. Install the text border to either text instruction component;
3. Scroll the text to the top.

Screenshot of the instructions with the fix

The stated issues are resolved:

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8350260: Improve HTML instruction formatting in PassFailJFrame (Bug - P4)

Reviewers

• Alexander Zuev (@azuev-java - Reviewer)
• Alexander Zvegintsev (@azvegint - Reviewer)
• Abhishek Kumar (@kumarabhi006 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23674/head:pull/23674
$ git checkout pull/23674

Update a local copy of the PR:
$ git checkout pull/23674
$ git pull https://git.openjdk.org/jdk.git pull/23674/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23674

View PR using the GUI difftool:
$ git pr show -t 23674

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23674.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back aivanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@aivanov-jdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8350260: Improve HTML instruction formatting in PassFailJFrame

Reviewed-by: kizune, azvegint, abhiscxk

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

• 4de92a4: 8350224: Test javax/swing/JComboBox/TestComboBoxComponentRendering.java fails in ubuntu 23.x and later
• 04659a4: 8350197: [UBSAN] Node::dump_idx reported float-cast-overflow
• 2d03bd0: 8350280: The JDK-8346050 testlibrary changes break the build
• f2b4e12: 8350263: JvmciNotifyBootstrapFinishedEventTest intermittently times out
• 46d4a60: 8349088: De-virtualize Codeblob and nmethod
• 62d93f2: 8346050: Update BuildTestLib.gmk to build whole testlibrary
• e1d0a9c: 8350202: Tune for Power10 CPUs on Linux ppc64le

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@aivanov-jdk The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (b8e5d887)

[azuev-java]

Looks reasonable. Especially scrolling to the beginning.

[aivanov-jdk]

Especially scrolling to the beginning.

That was the most disturbing thing. I didn't notice it before, because HTML instructions were never so long to have the vertical scroll bar.

[kumarabhi006]

Especially scrolling to the beginning.

That was the most disturbing thing. I didn't notice it before, because HTML instructions were never so long to have the vertical scroll bar.

I agree to this.
I didn't notice the clipping of number 10 before but With the changes in PFJ, test instructions look better.

[aivanov-jdk]

/integrate

[openjdk]

Going to push as commit 014701a.
Since your change was applied there have been 13 commits pushed to the master branch:

• 59810ad: 8350201: Out of bounds access on Linux aarch64 in os::print_register_info
• 2353f3e: 8350210: CTW: Use stackless exceptions
• 79db2d4: 8350159: compiler/tiered/Level2RecompilationTest.java fails after JDK-8349915
• d13fd57: 8350211: CTW: Attempt to preload all classes in constant pool
• 0ef1c40: 8350006: IGV: show memory slices as type information
• 9042aa8: 8339238: Update to use jtreg 7.5.1
• 4de92a4: 8350224: Test javax/swing/JComboBox/TestComboBoxComponentRendering.java fails in ubuntu 23.x and later
• 04659a4: 8350197: [UBSAN] Node::dump_idx reported float-cast-overflow
• 2d03bd0: 8350280: The JDK-8346050 testlibrary changes break the build
• f2b4e12: 8350263: JvmciNotifyBootstrapFinishedEventTest intermittently times out
• ... and 3 more: https://git.openjdk.org/jdk/compare/885be2efa6b1359a7c7ab36882e19a7eaba77fb3...master

Your commit was automatically rebased without conflicts.

[openjdk]

@aivanov-jdk Pushed as commit 014701a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.