6436374: Graphics.setColor(null) is not documented

[prsadhuk]

Document setting null setColor similar to way setFont(null) is documented.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-6436374: Graphics.setColor(null) is not documented

Reviewers

• Sergey Bylokhov (@mrserb - Reviewer)
• Pankaj Bansal (@pankaj-bansal - Reviewer) ⚠️ Review applies to dc4fe3c

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2371/head:pull/2371
$ git checkout pull/2371

[bridgekeeper]

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@prsadhuk The following label will be automatically applied to this pull request:

• 2d

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (a2c6c93)
• 00: Full (dc4fe3c)

[mrserb]

/csr

[openjdk]

@mrserb has indicated that a compatibility and specification (CSR) request is needed for this pull request.
@prsadhuk please create a CSR request and add link to it in JDK-6436374. This pull request cannot be integrated until the CSR request is approved.

[prsadhuk]

@mrserb has indicated that a compatibility and specification (CSR) request is needed for this pull request.
@prsadhuk please create a CSR request and add link to it in JDK-6436374. This pull request cannot be integrated until the CSR request is approved.

Done..JDK-8261018...Please review...

[mrserb]

While CSR is under review, maybe we can add a small test?

[prsadhuk]

What will be the objective of the test...It's just documentation change..no code is changed...setting null will be ignored before this and after this change...

[mrserb]

This change added a statement to the specification, which could not be tested before. So this new test will be the first one that passes a null to this method, how we will know that it is actually ignored?

[prsadhuk]

/label remove awt

[openjdk]

@prsadhuk
The awt label was successfully removed.

[openjdk]

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

6436374: Graphics.setColor(null) is not documented

Reviewed-by: serb, pbansal

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 40 new commits pushed to the master branch:

• f025bc1: 8260301: misc gc/g1/unloading tests fails with "RuntimeException: Method could not be enqueued for compilation at level N"
• 4a8b5c1: 8257858: [macOS]: Remove JNF dependency from libosxsecurity/KeystoreImpl.m
• 472bf62: 8258799: [Testbug] RandomCommandsTest must check if tested directive is added via jcmd
• b0ee7a8: 8241995: Clarify InetSocketAddress::toString specification
• 0ef93fe: 8259265: Refactor UncaughtExceptions shell test as java test.
• 5324b5c: 8260998: Shenandoah: Restore reference processing statistics reporting
• c8de943: 8260617: Merge ZipFile encoding check with the initial hash calculation
• ae2c5f0: 8260581: IGV: enhance node search
• 9037615: 8222850: jshell tool: Misleading cascade compiler error in switch expression with undefined vars
• 91e6c75: 8260928: InitArrayShortSize constraint func should print a helpful error message
• ... and 30 more: https://git.openjdk.java.net/jdk/compare/181d63ffcee7a2f03ed9b8278b5ffface71a494f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[prsadhuk]

/integrate

[openjdk]

@prsadhuk Since your change was applied there have been 57 commits pushed to the master branch:

• 82028e7: 8260012: Reduce inclusion of collectedHeap.hpp and heapInspection.hpp
• 9b7a8f1: Merge
• 1a7040e: 8259794: Remove EA from JDK 16 version string starting with Initial RC promotion on Feb 04, 2021(B35)
• afd5eef: 8260704: ParallelGC: oldgen expansion needs release-store for _end
• 081fa3e: 8260927: StringBuilder::insert is incorrect without Compact Strings
• ed1a775: 8258378: Final nroff manpage update for JDK 16
• 21f8bf4: 8257215: JFR: Events dropped when streaming over a chunk rotation
• 0fdf9cd: 8260473: [vector] ZGC: VectorReshape test produces incorrect results with ZGC enabled
• bc41bb1: 8260632: Build failures after JDK-8253353
• a117e11: 8260339: JVM crashes when executing PhaseIdealLoop::match_fill_loop
• ... and 47 more: https://git.openjdk.java.net/jdk/compare/181d63ffcee7a2f03ed9b8278b5ffface71a494f...master

Your commit was automatically rebased without conflicts.

Pushed as commit 60f440d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.