8350386: Test TestCodeCacheFull.java fails with option -XX:-UseCodeCacheFlushing

[sendaoYan]

Hi all,

Test jdk/jfr/event/compiler/TestCodeCacheFull.java fails with option -XX:-UseCodeCacheFlushing, because this test is incompatible with -XX:-UseCodeCacheFlushing when -XX:+SegmentedCodeCache is enable, the detail analyze has been recorded by JDK-8350386. This PR add * @requires vm.opt.UseCodeCacheFlushing == null | vm.opt.UseCodeCacheFlushing == true to make sure UseCodeCacheFlushing is not set or set as true.

Change has been verified locally, test-fix only, no risk.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8350386: Test TestCodeCacheFull.java fails with option -XX:-UseCodeCacheFlushing (Bug - P4)

Reviewers

• Thomas Schatzl (@tschatzl - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23721/head:pull/23721
$ git checkout pull/23721

Update a local copy of the PR:
$ git checkout pull/23721
$ git pull https://git.openjdk.org/jdk.git pull/23721/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23721

View PR using the GUI difftool:
$ git pr show -t 23721

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23721.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8350386: Test TestCodeCacheFull.java fails with option -XX:-UseCodeCacheFlushing

Reviewed-by: tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 363 new commits pushed to the master branch:

• de58009: 8351468: C2: array fill optimization assigns wrong type to intrinsic call
• a875733: 8352486: [ubsan] compilationMemoryStatistic.cpp:659:21: runtime error: index 64 out of bounds for type const struct unnamed struct
• 5591f8a: 8351515: C2 incorrectly removes double negation for double and float
• 56a4ffa: 8352597: [IR Framework] test bug: TestNotCompilable.java fails on product build
• e23e0f8: 8352591: Missing UnlockDiagnosticVMOptions in VerifyGraphEdgesWithDeadCodeCheckFromSafepoints test
• adfb120: 8351748: Add class init barrier to AOT-cached Method/Var Handles
• ee1577b: 8352652: [BACKOUT] nsk/jvmti/ tests should fail when nsk_jvmti_setFailStatus() is called
• df9210e: 8347706: jvmciEnv.cpp has jvmci includes out of order
• 5dd0acb: 8352477: RISC-V: Print warnings when unsupported intrinsics are enabled
• 334a1ee: 8351375: nsk/jvmti/ tests should fail when nsk_jvmti_setFailStatus() is called
• ... and 353 more: https://git.openjdk.org/jdk/compare/16033ea79a01b27a7f5cbb31d64da0e80afc7dc3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@sendaoYan The following label will be automatically applied to this pull request:

• hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (cf9a4353)
• 00: Full (5afda39f)

[bridgekeeper]

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[sendaoYan]

Hi, can anyone take look this PR.

[sendaoYan]

PR description has been updated.

[sendaoYan]

Thanks for the reviews @tschatzl

/integrate

[openjdk]

Going to push as commit ad48846.
Since your change was applied there have been 496 commits pushed to the master branch:

• 8b4e190: 8353349: ProblemList runtime/cds/appcds/SignedJar.java
• 860a789: 8353219: RISC-V: Fix client builds after JDK-8345298
• a83760a: 8352092: -XX:AOTMode=record crashes with InstanceKlass in allocated state
• 1077265: 8353321: [macos] ErrorTest.testAppContentWarning test case requires signing environment
• 52f56e6: 8353196: [macos] Contents of ".jpackage.xml" file are wrong when building .pkg from unsigned app image
• acd4da4: 8353299: VerifyJarEntryName.java test fails
• 5eee32d: 8352768: CDS test MethodHandleTest.java failed in -Xcomp mode
• 8b0602d: 8319447: Improve performance of delayed task handling
• fe8bd75: 8351290: Clarify integral only for vector operators
• 4d1de46: 8352185: Shenandoah: Invalid logic for remembered set verification
• ... and 486 more: https://git.openjdk.org/jdk/compare/16033ea79a01b27a7f5cbb31d64da0e80afc7dc3...master

Your commit was automatically rebased without conflicts.

[openjdk]

@sendaoYan Pushed as commit ad48846.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.