Skip to content

Conversation

@fguallini
Copy link
Member

@fguallini fguallini commented Feb 21, 2025

The test javax/crypto/CryptoPermissions/InconsistentEntries.java uses CDSTestUtils.clone to copy the JDK into the scratch dir by creating symbolic links, but this was seen to crash the VM in Windows Server 2025. To ensure test stability, it should hard copy the required files.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8350456: Test javax/crypto/CryptoPermissions/InconsistentEntries.java crashed: EXCEPTION_ACCESS_VIOLATION (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23726/head:pull/23726
$ git checkout pull/23726

Update a local copy of the PR:
$ git checkout pull/23726
$ git pull https://git.openjdk.org/jdk.git pull/23726/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23726

View PR using the GUI difftool:
$ git pr show -t 23726

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23726.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 21, 2025

👋 Welcome back fguallini! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 21, 2025

@fguallini This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8350456: Test javax/crypto/CryptoPermissions/InconsistentEntries.java crashed: EXCEPTION_ACCESS_VIOLATION

Reviewed-by: rhalade, jnimeh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • 9d9d7a1: 8349759: Add unit test for CertificateBuilder and SimpleOCSPServer test utilities
  • b45c32c: 8350287: Cleanup SA's support for CodeBlob subclasses
  • bd8ad30: 8350285: Shenandoah: Regression caused by ShenandoahLock under extreme contention
  • 24b5573: 8350444: Check for verifer error in StackMapReader::check_offset()
  • dfcd0df: 8350019: HttpClient: DelegatingExecutor should resort to the fallback executor only on RejectedExecutionException
  • 1b6281d: 8321003: RISC-V: C2 MulReductionVI
  • c73fead: 8350383: Test: add more test case for string compare (UL case)

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jnimeh, @rhalade) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk
Copy link

openjdk bot commented Feb 21, 2025

@fguallini The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Feb 21, 2025
@fguallini fguallini changed the title Test javax/crypto/CryptoPermissions/InconsistentEntries.java crashed: EXCEPTION_ACCESS_VIOLATION 8350456: Test javax/crypto/CryptoPermissions/InconsistentEntries.java crashed: EXCEPTION_ACCESS_VIOLATION Feb 21, 2025
@fguallini fguallini marked this pull request as ready for review February 21, 2025 19:59
@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 21, 2025
@mlbridge
Copy link

mlbridge bot commented Feb 21, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 21, 2025
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Feb 21, 2025
@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 21, 2025
@fguallini
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Feb 21, 2025
@openjdk
Copy link

openjdk bot commented Feb 21, 2025

@fguallini
Your change (at version fbd3587) is now ready to be sponsored by a Committer.

@rhalade
Copy link
Member

rhalade commented Feb 21, 2025

/sponsor

@openjdk
Copy link

openjdk bot commented Feb 21, 2025

Going to push as commit 825ab20.
Since your change was applied there have been 7 commits pushed to the master branch:

  • 9d9d7a1: 8349759: Add unit test for CertificateBuilder and SimpleOCSPServer test utilities
  • b45c32c: 8350287: Cleanup SA's support for CodeBlob subclasses
  • bd8ad30: 8350285: Shenandoah: Regression caused by ShenandoahLock under extreme contention
  • 24b5573: 8350444: Check for verifer error in StackMapReader::check_offset()
  • dfcd0df: 8350019: HttpClient: DelegatingExecutor should resort to the fallback executor only on RejectedExecutionException
  • 1b6281d: 8321003: RISC-V: C2 MulReductionVI
  • c73fead: 8350383: Test: add more test case for string compare (UL case)

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 21, 2025
@openjdk openjdk bot closed this Feb 21, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Feb 21, 2025
@openjdk
Copy link

openjdk bot commented Feb 21, 2025

@rhalade @fguallini Pushed as commit 825ab20.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated security security-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

3 participants