-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8350456: Test javax/crypto/CryptoPermissions/InconsistentEntries.java crashed: EXCEPTION_ACCESS_VIOLATION #23726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back fguallini! A progress list of the required criteria for merging this PR into |
|
@fguallini This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 7 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jnimeh, @rhalade) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
@fguallini The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
|
/integrate |
|
@fguallini |
|
/sponsor |
|
Going to push as commit 825ab20.
Your commit was automatically rebased without conflicts. |
|
@rhalade @fguallini Pushed as commit 825ab20. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
The test javax/crypto/CryptoPermissions/InconsistentEntries.java uses CDSTestUtils.clone to copy the JDK into the scratch dir by creating symbolic links, but this was seen to crash the VM in Windows Server 2025. To ensure test stability, it should hard copy the required files.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23726/head:pull/23726$ git checkout pull/23726Update a local copy of the PR:
$ git checkout pull/23726$ git pull https://git.openjdk.org/jdk.git pull/23726/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 23726View PR using the GUI difftool:
$ git pr show -t 23726Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23726.diff
Using Webrev
Link to Webrev Comment