8350499: Minimal build fails with slowdebug builds

[theaoqi]

minimal build fails with slowdebug builds after 8311208 (permissions required):

Building target 'images' in configuration 'linux-x86_64-minimal-slowdebug'
/usr/bin/ld: /home/aoqi/work/theaoqi/jdk/build/linux-x86_64-minimal-slowdebug/hotspot/variant-minimal/libjvm/objs/verifier.o: in function `Verifier::verify(InstanceKlass*, bool, JavaThread*)':
/home/aoqi/work/theaoqi/jdk/src/hotspot/share/classfile/verifier.cpp:239: undefined reference to `SystemDictionaryShared::warn_excluded(InstanceKlass*, char const*)'
/usr/bin/ld: /home/aoqi/work/theaoqi/jdk/src/hotspot/share/classfile/verifier.cpp:240: undefined reference to `SystemDictionaryShared::set_excluded(InstanceKlass*)'
collect2: error: ld returned 1 exit status
gmake[3]: *** [lib/CompileJvm.gmk:174: /home/aoqi/work/theaoqi/jdk/build/linux-x86_64-minimal-slowdebug/support/modules_libs/java.base/minimal/libjvm.so] Error 1
gmake[2]: *** [make/Main.gmk:236: hotspot-minimal-libs] Error 2

ERROR: Build failed for target 'images' in configuration 'linux-x86_64-minimal-slowdebug' (exit code 2) 

It may be because the systemDictionaryShared.cpp file is excluded when using slowdebug and minimal builds.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8350499: Minimal build fails with slowdebug builds (Bug - P4)

Reviewers

• Kim Barrett (@kimbarrett - Reviewer)
• David Holmes (@dholmes-ora - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23729/head:pull/23729
$ git checkout pull/23729

Update a local copy of the PR:
$ git checkout pull/23729
$ git pull https://git.openjdk.org/jdk.git pull/23729/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23729

View PR using the GUI difftool:
$ git pr show -t 23729

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23729.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back aoqi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@theaoqi This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8350499: Minimal build fails with slowdebug builds

Reviewed-by: kbarrett, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

• 05b4812: 8350041: Skip test/jdk/java/lang/String/nativeEncoding/StringPlatformChars.java on static JDK
• a891630: 8350480: RISC-V: Relax assertion about registers in C2_MacroAssembler::minmax_fp
• 5cbd9d1: 8349959: Test CR6740048.java passes unexpectedly missing CR6740048.xsd
• 25322aa: 8350258: AArch64: Client build fails after JDK-8347917
• 825ab20: 8350456: Test javax/crypto/CryptoPermissions/InconsistentEntries.java crashed: EXCEPTION_ACCESS_VIOLATION
• 9d9d7a1: 8349759: Add unit test for CertificateBuilder and SimpleOCSPServer test utilities
• b45c32c: 8350287: Cleanup SA's support for CodeBlob subclasses
• bd8ad30: 8350285: Shenandoah: Regression caused by ShenandoahLock under extreme contention
• 24b5573: 8350444: Check for verifer error in StackMapReader::check_offset()

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@kimbarrett, @dholmes-ora) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@theaoqi The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (56004f64)
• 00: Full (b5e8fce8)

[dholmes-ora]

Looks good. Thanks for fixing this.

[theaoqi]

Thanks for the reviews!
/integrate

[openjdk]

@theaoqi
Your change (at version 56004f6) is now ready to be sponsored by a Committer.

[dholmes-ora]

/sponsor

[openjdk]

Going to push as commit 302bed0.
Since your change was applied there have been 10 commits pushed to the master branch:

• 0795d11: 8350464: The flags to set the native priority for the VMThread and Java threads need a broader range
• 05b4812: 8350041: Skip test/jdk/java/lang/String/nativeEncoding/StringPlatformChars.java on static JDK
• a891630: 8350480: RISC-V: Relax assertion about registers in C2_MacroAssembler::minmax_fp
• 5cbd9d1: 8349959: Test CR6740048.java passes unexpectedly missing CR6740048.xsd
• 25322aa: 8350258: AArch64: Client build fails after JDK-8347917
• 825ab20: 8350456: Test javax/crypto/CryptoPermissions/InconsistentEntries.java crashed: EXCEPTION_ACCESS_VIOLATION
• 9d9d7a1: 8349759: Add unit test for CertificateBuilder and SimpleOCSPServer test utilities
• b45c32c: 8350287: Cleanup SA's support for CodeBlob subclasses
• bd8ad30: 8350285: Shenandoah: Regression caused by ShenandoahLock under extreme contention
• 24b5573: 8350444: Check for verifer error in StackMapReader::check_offset()

Your commit was automatically rebased without conflicts.

[openjdk]

@dholmes-ora @theaoqi Pushed as commit 302bed0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.