8350524: Some hotspot/jtreg/serviceability/dcmd/vm tier1 tests fail on static JDK #23734

jianglizhou · 2025-02-22T03:31:53Z

Please review the fix in following tests to not check for shared libraries when running on static JDK:

test/hotspot/jtreg/serviceability/dcmd/vm/DynLibsTest.java
test/hotspot/jtreg/serviceability/dcmd/vm/SystemDumpMapTest.java
test/hotspot/jtreg/serviceability/dcmd/vm/SystemMapTest.java

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8350524: Some hotspot/jtreg/serviceability/dcmd/vm tier1 tests fail on static JDK (Bug - P4)

Reviewers

Thomas Stuefe (@tstuefe - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23734/head:pull/23734
$ git checkout pull/23734

Update a local copy of the PR:
$ git checkout pull/23734
$ git pull https://git.openjdk.org/jdk.git pull/23734/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23734

View PR using the GUI difftool:
$ git pr show -t 23734

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23734.diff

Using Webrev

Link to Webrev Comment

bridgekeeper · 2025-02-22T03:32:38Z

👋 Welcome back jiangli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2025-02-22T03:33:20Z

@jianglizhou This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8350524: Some hotspot/jtreg/serviceability/dcmd/vm tier1 tests fail on static JDK

Reviewed-by: stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 261 new commits pushed to the master branch:

a7a09f6: 8349632: RISC-V: Add Zfa fminm/fmaxm
0454406: 8351987: ProblemList the failing JFR streaming tests on macOS
be36b23: 8351778: JIT compiler fails when running -XX:AOTMode=create
7fc776e: 8270265: LineBreakMeasurer calculates incorrect line breaks with zero-width characters
3da5e3f: 8349350: Unable to print using InputSlot and OutputBin print attributes at the same time
aa047ee: 8319192: Remove javax.swing.plaf.synth.SynthLookAndFeel.load(URL url)
cd1be91: 8319055: JCMD should not buffer the whole output of commands
248c373: 8351266: JFR: -XX:StartFlightRecording:report-on-exit
03ef79c: 8346470: Improve WriteBarrier JMH to have old-to-young refs
b50fe9b: 8280818: Expand bug8033699.java to iterate over all LaFs
... and 251 more: https://git.openjdk.org/jdk/compare/25322aae8e224680db376098d2e45f26cf3334a0...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2025-02-22T03:33:48Z

@jianglizhou The following label will be automatically applied to this pull request:

serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2025-02-22T03:37:33Z

Webrevs

01: Full - Incremental (d1975464)
00: Full (25f2db29)

jianglizhou · 2025-02-27T21:06:49Z

@tstuefe Could you please help review these test changes? Looking at the file history, I see you added the SystemDumpMapTest.java and SystemMapTest.java. Thanks

AlanBateman · 2025-03-04T19:05:57Z

I'm not familiar with details of the output from the System.map command but the change looks reasonable, hopefully @tstuefe or someone familar with this command and these tests can review.

jianglizhou · 2025-03-13T16:51:44Z

I'm not familiar with details of the output from the System.map command but the change looks reasonable, hopefully @tstuefe or someone familar with this command and these tests can review.

Thanks, @AlanBateman!

Could anyone help review this change as well? Thanks!

tstuefe

Small nits, otherwise fine.

tstuefe · 2025-03-13T19:35:27Z

test/hotspot/jtreg/serviceability/dcmd/vm/SystemMapTestBase.java

+            // libjvm
+            regexBase_committed + "/lib/.*/libjvm.so"
+        };
+


Nit, misnamed, since its not unconditionally anymore.

Done. Also renamed for other OSs.

tstuefe · 2025-03-13T19:36:52Z

test/hotspot/jtreg/serviceability/dcmd/vm/SystemMapTestBase.java

+                return shouldMatchUnconditionally_linux;
+            } else {
+                return StringArrayUtils.concat(shouldMatchUnconditionally_linux,
+                                               shouldMatchUnconditionally_linux_libjvm);


Here, and in DumpTest: please provide a short comment about why we don't want to match libjvm (even if it seems obvious).

Add comments. Please let me know if that covers all cases in your suggestion.

@tstuefe Could you please approve again after the updates? Thanks for the review!

- Renamed shouldMatchUnconditionally_<os>_libjvm to shouldMatch_<os>_libjvm in SystemMapTestBase. - Added comments to shouldMatchUnconditionally() methods for difference OS cases in SystemMapTestBase. - Added comments to DynLibsTest.java.

tstuefe

Good, thanks for addressing the nits

jianglizhou · 2025-03-14T16:24:03Z

Thanks, @tstuefe!

jianglizhou · 2025-03-14T16:24:09Z

/integrate

openjdk · 2025-03-14T16:25:25Z

Going to push as commit 7f42804.
Since your change was applied there have been 266 commits pushed to the master branch:

712a70c: 8318220: RISC-V: C2 ReverseI
985ca12: 8352011: RISC-V: Two IR tests fail after JDK-8351662
86b2433: 8352050: Problem list compiler/ciReplay/* test until JDK-8349191 is fixed
65c5282: 8351938: C2: Print compilation bailouts with PrintCompilation compile command
e3c29c9: 8351556: Optimize Location.locationFor/isModuleOrientedLocation
a7a09f6: 8349632: RISC-V: Add Zfa fminm/fmaxm
0454406: 8351987: ProblemList the failing JFR streaming tests on macOS
be36b23: 8351778: JIT compiler fails when running -XX:AOTMode=create
7fc776e: 8270265: LineBreakMeasurer calculates incorrect line breaks with zero-width characters
3da5e3f: 8349350: Unable to print using InputSlot and OutputBin print attributes at the same time
... and 256 more: https://git.openjdk.org/jdk/compare/25322aae8e224680db376098d2e45f26cf3334a0...master

Your commit was automatically rebased without conflicts.

openjdk · 2025-03-14T16:25:39Z

@jianglizhou Pushed as commit 7f42804.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

jianglizhou added 3 commits February 21, 2025 16:51

Don't look for shared libraries on static JDK.

958ae07

Remove unneeded import jdk.test.whitebox.WhiteBox;

5d85edf

Update copyright headers.

25f2db2

openjdk bot added the rfr Pull request is ready for review label Feb 22, 2025

openjdk bot added the serviceability serviceability-dev@openjdk.org label Feb 22, 2025

tstuefe approved these changes Mar 13, 2025

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Mar 13, 2025

Address @tstuefe review:

d197546

- Renamed shouldMatchUnconditionally_<os>_libjvm to shouldMatch_<os>_libjvm in SystemMapTestBase. - Added comments to shouldMatchUnconditionally() methods for difference OS cases in SystemMapTestBase. - Added comments to DynLibsTest.java.

openjdk bot removed the ready Pull request is ready to be integrated label Mar 13, 2025

tstuefe approved these changes Mar 14, 2025

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Mar 14, 2025

openjdk bot added the integrated Pull request has been integrated label Mar 14, 2025

openjdk bot closed this Mar 14, 2025

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 14, 2025

8350524: Some hotspot/jtreg/serviceability/dcmd/vm tier1 tests fail on static JDK #23734

8350524: Some hotspot/jtreg/serviceability/dcmd/vm tier1 tests fail on static JDK #23734

Uh oh!

Conversation

jianglizhou commented Feb 22, 2025 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Feb 22, 2025

Uh oh!

openjdk bot commented Feb 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk bot commented Feb 22, 2025

Uh oh!

mlbridge bot commented Feb 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

jianglizhou commented Feb 27, 2025

Uh oh!

AlanBateman commented Mar 4, 2025

Uh oh!

jianglizhou commented Mar 13, 2025

Uh oh!

tstuefe left a comment

Choose a reason for hiding this comment

Uh oh!

tstuefe Mar 13, 2025

Choose a reason for hiding this comment

Uh oh!

jianglizhou Mar 13, 2025

Choose a reason for hiding this comment

Uh oh!

tstuefe Mar 13, 2025

Choose a reason for hiding this comment

Uh oh!

jianglizhou Mar 13, 2025

Choose a reason for hiding this comment

Uh oh!

tstuefe left a comment

Choose a reason for hiding this comment

Uh oh!

jianglizhou commented Mar 14, 2025

Uh oh!

jianglizhou commented Mar 14, 2025

Uh oh!

openjdk bot commented Mar 14, 2025

Uh oh!

openjdk bot commented Mar 14, 2025

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

jianglizhou commented Feb 22, 2025 •

edited by openjdk bot

Loading

openjdk bot commented Feb 22, 2025 •

edited

Loading

mlbridge bot commented Feb 22, 2025 •

edited

Loading