Skip to content

8314840: 3 gc/epsilon tests ignore external vm options#23751

Closed
rsunderbabu wants to merge 1 commit intoopenjdk:masterfrom
rsunderbabu:8314840
Closed

8314840: 3 gc/epsilon tests ignore external vm options#23751
rsunderbabu wants to merge 1 commit intoopenjdk:masterfrom
rsunderbabu:8314840

Conversation

@rsunderbabu
Copy link
Member

@rsunderbabu rsunderbabu commented Feb 24, 2025

These tests do not pass Java/JVM test command line options (flags) to the child process. More details in JBS.
Tiers 1 to 3 tested. Along with various flag combinations.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8314840: 3 gc/epsilon tests ignore external vm options (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23751/head:pull/23751
$ git checkout pull/23751

Update a local copy of the PR:
$ git checkout pull/23751
$ git pull https://git.openjdk.org/jdk.git pull/23751/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23751

View PR using the GUI difftool:
$ git pr show -t 23751

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23751.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 24, 2025

👋 Welcome back rsunderbabu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 24, 2025

@rsunderbabu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8314840: 3 gc/epsilon tests ignore external vm options

Reviewed-by: tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 87 new commits pushed to the master branch:

  • 78c18cf: 8349399: GHA: Add static-jdk build on linux-x64
  • e43960a: 8350616: Skip ValidateHazardPtrsClosure in non-debug builds
  • 9ec4696: 8350313: Include timings for leaving safepoint in safepoint logging
  • ec6624b: 8350649: Class unloading accesses/resurrects dead Java mirror after JDK-8346567
  • 9477c70: 8024695: new File("").exists() returns false whereas it is the current working directory
  • 3e46480: 8350770: [BACKOUT] Protection zone for easier detection of accidental zero-nKlass use
  • bd112c4: 8350443: GHA: Split static-libs-bundles into a separate job
  • 2731712: 8287749: Re-enable javadoc -serialwarn option
  • 0f82268: 8345598: Upgrade NSS binaries for interop tests
  • ea2c923: 8323807: Async UL: Add a stalling mode to async UL
  • ... and 77 more: https://git.openjdk.org/jdk/compare/efbad00c4d7931177ccc5e9bce3b30dfbac94010...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@tschatzl) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 24, 2025
@openjdk
Copy link

openjdk bot commented Feb 24, 2025

@rsunderbabu The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Feb 24, 2025
@mlbridge
Copy link

mlbridge bot commented Feb 24, 2025

Webrevs

Copy link
Contributor

@tschatzl tschatzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 26, 2025
@rsunderbabu
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Feb 27, 2025
@openjdk
Copy link

openjdk bot commented Feb 27, 2025

@rsunderbabu
Your change (at version a83a03b) is now ready to be sponsored by a Committer.

@rsunderbabu
Copy link
Member Author

Please sponsor.

@sendaoYan
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Feb 27, 2025

Going to push as commit 799ac52.
Since your change was applied there have been 95 commits pushed to the master branch:

  • 63e0fc4: 8350841: ProblemList jdk/incubator/vector/Long256VectorTests.java
  • acc6f19: 8350614: [JMH] jdk.incubator.vector.VectorCommutativeOperSharingBenchmark fails
  • 01bd7e4: 8350314: Shenandoah: Capture thread state sync times in GC timings
  • 4522f12: 8349921: Crash in codeBuffer.cpp:1004: guarantee(sect->end() <= tend) failed: sanity
  • e4d3c97: 8350111: [PPC] AsyncGetCallTrace crashes when called while handling SIGTRAP
  • 885338b: 8323582: C2 SuperWord AlignVector: misaligned vector memory access with unaligned native memory
  • bb48b73: 8350723: RISC-V: debug.cpp help() is missing riscv line for pns
  • b29f8b0: 8350665: SIZE_FORMAT_HEX macro undefined in gtest
  • 78c18cf: 8349399: GHA: Add static-jdk build on linux-x64
  • e43960a: 8350616: Skip ValidateHazardPtrsClosure in non-debug builds
  • ... and 85 more: https://git.openjdk.org/jdk/compare/efbad00c4d7931177ccc5e9bce3b30dfbac94010...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 27, 2025
@openjdk openjdk bot closed this Feb 27, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Feb 27, 2025
@openjdk
Copy link

openjdk bot commented Feb 27, 2025

@sendaoYan @rsunderbabu Pushed as commit 799ac52.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@rsunderbabu
Copy link
Member Author

Thanks @tschatzl and @sendaoYan

@rsunderbabu rsunderbabu deleted the 8314840 branch August 13, 2025 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants