Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8261030: Avoid loading GenerateJLIClassesHelper at runtime #2376

Closed
wants to merge 3 commits into from

Conversation

@cl4es
Copy link
Member

@cl4es cl4es commented Feb 3, 2021

This moves the tracing methods added to GenerateJLIClassesHelper in JDK-8252725 to MethodHandleStatics, which avoids loading at runtime some code meant for jlink.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8261030: Avoid loading GenerateJLIClassesHelper at runtime

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2376/head:pull/2376
$ git checkout pull/2376

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 3, 2021

👋 Welcome back redestad! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Feb 3, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 3, 2021

@cl4es The following labels will be automatically applied to this pull request:

  • core-libs
  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 3, 2021

Webrevs

@mlchung
Copy link
Member

@mlchung mlchung commented Feb 3, 2021

/label remove hotspot-compiler

@openjdk openjdk bot removed the hotspot-compiler label Feb 3, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 3, 2021

@mlchung
The hotspot-compiler label was successfully removed.

@openjdk
Copy link

@openjdk openjdk bot commented Feb 3, 2021

@cl4es This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8261030: Avoid loading GenerateJLIClassesHelper at runtime

Reviewed-by: mchung

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 30 new commits pushed to the master branch:

  • 2be60e3: 8257988: Remove JNF dependency from libsaproc/MacosxDebuggerLocal.m
  • f025bc1: 8260301: misc gc/g1/unloading tests fails with "RuntimeException: Method could not be enqueued for compilation at level N"
  • 4a8b5c1: 8257858: [macOS]: Remove JNF dependency from libosxsecurity/KeystoreImpl.m
  • 472bf62: 8258799: [Testbug] RandomCommandsTest must check if tested directive is added via jcmd
  • b0ee7a8: 8241995: Clarify InetSocketAddress::toString specification
  • 0ef93fe: 8259265: Refactor UncaughtExceptions shell test as java test.
  • 5324b5c: 8260998: Shenandoah: Restore reference processing statistics reporting
  • c8de943: 8260617: Merge ZipFile encoding check with the initial hash calculation
  • ae2c5f0: 8260581: IGV: enhance node search
  • 9037615: 8222850: jshell tool: Misleading cascade compiler error in switch expression with undefined vars
  • ... and 20 more: https://git.openjdk.java.net/jdk/compare/ddd2951ba91fe3860b92d2f9bad4e0d900f1d650...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 3, 2021
@cl4es
Copy link
Member Author

@cl4es cl4es commented Feb 4, 2021

/integrate

@openjdk openjdk bot closed this Feb 4, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 4, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 4, 2021

@cl4es Since your change was applied there have been 50 commits pushed to the master branch:

  • 992b500: 8261036: Reduce classes loaded by CleanerFactory initialization
  • e8ad8b3: 8259956: jdk.jfr.internal.ChunkInputStream#available should return the sum of remaining available bytes
  • 06b33a0: 8261107: ArrayIndexOutOfBoundsException in the ICC_Profile.getInstance(InputStream)
  • 60f440d: 6436374: Graphics.setColor(null) is not documented
  • 82028e7: 8260012: Reduce inclusion of collectedHeap.hpp and heapInspection.hpp
  • 9b7a8f1: Merge
  • 1a7040e: 8259794: Remove EA from JDK 16 version string starting with Initial RC promotion on Feb 04, 2021(B35)
  • afd5eef: 8260704: ParallelGC: oldgen expansion needs release-store for _end
  • 081fa3e: 8260927: StringBuilder::insert is incorrect without Compact Strings
  • ed1a775: 8258378: Final nroff manpage update for JDK 16
  • ... and 40 more: https://git.openjdk.java.net/jdk/compare/ddd2951ba91fe3860b92d2f9bad4e0d900f1d650...master

Your commit was automatically rebased without conflicts.

Pushed as commit 83357b1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants