8350614: [JMH] jdk.incubator.vector.VectorCommutativeOperSharingBenchmark fails

[sendaoYan]

Hi all,

The newly added JMH test jdk.incubator.vector.VectorCommutativeOperSharingBenchmark run fails "java.lang.NoClassDefFoundError: jdk/incubator/vector/Vector".

The @Fork(jvmArgsPrepend = ..) in microbenchmarks should replaced as @Fork(jvmArgs = ..) after JDK-8343345. Change has been verified locally, test-fix only, no risk.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8350614: [JMH] jdk.incubator.vector.VectorCommutativeOperSharingBenchmark fails (Bug - P4)

Reviewers

• Claes Redestad (@cl4es - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23761/head:pull/23761
$ git checkout pull/23761

Update a local copy of the PR:
$ git checkout pull/23761
$ git pull https://git.openjdk.org/jdk.git pull/23761/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23761

View PR using the GUI difftool:
$ git pr show -t 23761

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23761.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8350614: [JMH] jdk.incubator.vector.VectorCommutativeOperSharingBenchmark fails

Reviewed-by: redestad

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 49 new commits pushed to the master branch:

• 01bd7e4: 8350314: Shenandoah: Capture thread state sync times in GC timings
• 4522f12: 8349921: Crash in codeBuffer.cpp:1004: guarantee(sect->end() <= tend) failed: sanity
• e4d3c97: 8350111: [PPC] AsyncGetCallTrace crashes when called while handling SIGTRAP
• 885338b: 8323582: C2 SuperWord AlignVector: misaligned vector memory access with unaligned native memory
• bb48b73: 8350723: RISC-V: debug.cpp help() is missing riscv line for pns
• b29f8b0: 8350665: SIZE_FORMAT_HEX macro undefined in gtest
• 78c18cf: 8349399: GHA: Add static-jdk build on linux-x64
• e43960a: 8350616: Skip ValidateHazardPtrsClosure in non-debug builds
• 9ec4696: 8350313: Include timings for leaving safepoint in safepoint logging
• ec6624b: 8350649: Class unloading accesses/resurrects dead Java mirror after JDK-8346567
• ... and 39 more: https://git.openjdk.org/jdk/compare/990d40e98da2ceb3261096eaa55550565af58fc1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@sendaoYan The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (28aeb449)

[jaikiran]

The micro benchmark test, which this PR is fixing was introduced just yesterday through #22863. I'll remove the core-libs label from this PR and add hotspot-compiler, given the original change which introduced this test.

[jaikiran]

/label add hotspot-compiler

[jaikiran]

/label remove core-libs

[openjdk]

@jaikiran
The hotspot-compiler label was successfully added.

[openjdk]

@jaikiran
The core-libs label was successfully removed.

[eme64]

@cl4es made the change in JDK-8343345, so he should probably have a quick look at this.

[cl4es]

LGTM

Yes, please use only jvmArgs in @Fork annotations. While the distinction between jvmArgs, -Prepend and -Append is subtle and somewhat arbitrary we opted (JDK-8342958 + JDK-8343345) to designate jvmArgs to be used in benchmark annotations to set benchmark-specific flags, reserving jvmArgsPrepend for use by make test or whatever benchmarking harness you might use to set up environment flags (such as the native library path), and leaving jvmArgsAppend for command line extras (specifying GC etc).

[sendaoYan]

Thanks all for the reviews.

/integrate

[openjdk]

Going to push as commit acc6f19.
Since your change was applied there have been 49 commits pushed to the master branch:

• 01bd7e4: 8350314: Shenandoah: Capture thread state sync times in GC timings
• 4522f12: 8349921: Crash in codeBuffer.cpp:1004: guarantee(sect->end() <= tend) failed: sanity
• e4d3c97: 8350111: [PPC] AsyncGetCallTrace crashes when called while handling SIGTRAP
• 885338b: 8323582: C2 SuperWord AlignVector: misaligned vector memory access with unaligned native memory
• bb48b73: 8350723: RISC-V: debug.cpp help() is missing riscv line for pns
• b29f8b0: 8350665: SIZE_FORMAT_HEX macro undefined in gtest
• 78c18cf: 8349399: GHA: Add static-jdk build on linux-x64
• e43960a: 8350616: Skip ValidateHazardPtrsClosure in non-debug builds
• 9ec4696: 8350313: Include timings for leaving safepoint in safepoint logging
• ec6624b: 8350649: Class unloading accesses/resurrects dead Java mirror after JDK-8346567
• ... and 39 more: https://git.openjdk.org/jdk/compare/990d40e98da2ceb3261096eaa55550565af58fc1...master

Your commit was automatically rebased without conflicts.

[openjdk]

@sendaoYan Pushed as commit acc6f19.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.