8350565: NMT: remaining memory flag/type to be replaced with memory tag

[afshin-zafari]

There were some remaining flag or type for Memory Tag contexts.

Tests:
gtest:NMT* and runtime/NMT sets of tasks all passed.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8350565: NMT: remaining memory flag/type to be replaced with memory tag (Enhancement - P4)

Reviewers

• Gerard Ziemski (@gerard-ziemski - Reviewer)
• Johan Sjölen (@jdksjolen - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23769/head:pull/23769
$ git checkout pull/23769

Update a local copy of the PR:
$ git checkout pull/23769
$ git pull https://git.openjdk.org/jdk.git pull/23769/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23769

View PR using the GUI difftool:
$ git pr show -t 23769

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23769.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back azafari! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@afshin-zafari This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8350565: NMT: remaining memory flag/type to be replaced with memory tag

Reviewed-by: gziemski, jsjolen

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 154 new commits pushed to the master branch:

• 0892913: 8351086: (fc) Make java/nio/channels/FileChannel/BlockDeviceSize.java test manual
• 93f2260: 8351294: (fs) Minor verbiage correction for Files.createTemp{Directory,File}
• 8f8a879: 8350939: Revisit Windows PDH buffer size calculation for OperatingSystemMXBean
• cfab88b: 8351256: Improve printing of runtime call stub names in disassember output
• 7a5acb9: 8343840: Rewrite the ObjectMonitor lists
• 40f150d: 8330936: [ubsan] exclude function BilinearInterp and ShapeSINextSpan in libawt java2d from ubsan checks
• 649ef77: 8323158: HotSpot Style Guide should specify more include ordering
• 5c552a9: 8349358: [JMH] Cannot access class jdk.internal.vm.ContinuationScope
• e82031e: 8350756: C2 SuperWord Multiversioning: remove useless slow loop when the fast loop disappears
• 3626ac3: 8204868: java/util/zip/ZipFile/TestCleaner.java still fails with "cleaner failed to clean zipfile."
• ... and 144 more: https://git.openjdk.org/jdk/compare/e410af00e69587b86536b298b869ddc898fd9862...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@afshin-zafari To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels

• build
• client
• compiler
• core-libs
• graal
• hotspot
• hotspot-compiler
• hotspot-gc
• hotspot-jfr
• hotspot-runtime
• i18n
• ide-support
• javadoc
• jdk
• jmx
• kulla
• net
• nio
• security
• serviceability
• shenandoah

[afshin-zafari]

/label runtime

[openjdk]

@afshin-zafari
The label runtime is not a valid label.
These labels are valid:

• graal
• serviceability
• hotspot
• hotspot-compiler
• ide-support
• kulla
• i18n
• shenandoah
• jdk
• javadoc
• security
• hotspot-runtime
• jmx
• build
• nio
• client
• core-libs
• compiler
• net
• hotspot-gc
• hotspot-jfr

[afshin-zafari]

/label hotspot-runtime

[openjdk]

@afshin-zafari
The hotspot-runtime label was successfully added.

[mlbridge]

Webrevs

• 00: Full (8f6ba713)

[gerard-ziemski]

Thank you very much for cleaning up this technical debt stuff. I really appreciate this work!

LGTM

[jdksjolen]

LGTM, cheers

[afshin-zafari]

Thank you @gerard-ziemski and @jdksjolen for your reviews.
/integrate

[openjdk]

Going to push as commit 4066f33.
Since your change was applied there have been 157 commits pushed to the master branch:

• 7314efc: 8351377: Fix the ProblemList for com/sun/management/OperatingSystemMXBean cpuLoad tests on AIX
• 7c9a784: 8351223: Update localized resources in keytool and jarsigner
• a23fb0a: 8348110: Update LCMS to 2.17
• 0892913: 8351086: (fc) Make java/nio/channels/FileChannel/BlockDeviceSize.java test manual
• 93f2260: 8351294: (fs) Minor verbiage correction for Files.createTemp{Directory,File}
• 8f8a879: 8350939: Revisit Windows PDH buffer size calculation for OperatingSystemMXBean
• cfab88b: 8351256: Improve printing of runtime call stub names in disassember output
• 7a5acb9: 8343840: Rewrite the ObjectMonitor lists
• 40f150d: 8330936: [ubsan] exclude function BilinearInterp and ShapeSINextSpan in libawt java2d from ubsan checks
• 649ef77: 8323158: HotSpot Style Guide should specify more include ordering
• ... and 147 more: https://git.openjdk.org/jdk/compare/e410af00e69587b86536b298b869ddc898fd9862...master

Your commit was automatically rebased without conflicts.

[openjdk]

@afshin-zafari Pushed as commit 4066f33.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[tstuefe]

In older code I used to use the term "category" for a while, you can see this e.g. in the memlimit handling. Maybe you want to change that too? No strong feelings from me, if you want to leave it that is fine too. I'll approve the PR as it is now.

[tstuefe]

+1

[afshin-zafari]

Thank you @tstuefe for your valuable info. Unfortunately, I have already integrated the PR.
I will do the change in a future PR.