8350643: G1: Make loop iteration variable type correspond to limit in G1SurvRateGroup

[tschatzl]

Hi all,

in the G1SurvRateGroup class there are three loops that use a size_t loop iteration variable that is compared to uints in the condition, causing some implicit narrowing.

Change the loop variables to also use uints.

Pointed out by @kimbarrett during review of JDK-8349906.

Testing: local compilation, GHA, checking other loop variables to match type

Thanks,
Thomas

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8350643: G1: Make loop iteration variable type correspond to limit in G1SurvRateGroup (Enhancement - P4)

Reviewers

• Kim Barrett (@kimbarrett - Reviewer) Review applies to 51347fc1
• Albert Mingkun Yang (@albertnetymk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23773/head:pull/23773
$ git checkout pull/23773

Update a local copy of the PR:
$ git checkout pull/23773
$ git pull https://git.openjdk.org/jdk.git pull/23773/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23773

View PR using the GUI difftool:
$ git pr show -t 23773

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23773.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8350643: G1: Make loop iteration variable type correspond to limit in G1SurvRateGroup

Reviewed-by: ayang, kbarrett

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@tschatzl The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full (9cf34897)
• 00: Full (51347fc1)

[kimbarrett]

Looks good.

[tschatzl]

Thanks @albertnetymk @kimbarrett for your reviews
/integrate

[openjdk]

@tschatzl Since your change was applied there have been 26 commits pushed to the master branch:

• aac9cb4: 8349906: G1: Improve initial survivor rate for newly used young regions
• a431046: 8350518: org.openjdk.bench.java.util.TreeMapUpdate.compute fails with "java.lang.IllegalArgumentException: key out of range"
• a70eba8: 8330174: Protection zone for easier detection of accidental zero-nKlass use
• f529bf7: 8350483: AArch64: turn on signum intrinsics by default on Ampere CPUs
• 037e471: 8350666: cmp-baseline builds fail after JDK-8280682
• c8a521f: 8345213: JVM Prefers /etc/timezone Over /etc/localtime on Debian 12
• 86024eb: 8348426: Generate binary file for -XX:AOTMode=record -XX:AOTConfiguration=file
• 267d69b: 8326447: jpackage creates Windows installers that cannot be signed
• 2efb033: 8350601: Miscellaneous updates to jpackage test lib
• d4fdc79: 8344981: [REDO] JDK-6672644 JComboBox still scrolling if switch to another window and return back
• ... and 16 more: https://git.openjdk.org/jdk/compare/d551dacaef938cea0cad10047b79a0a7a26dcacb...master

It was not possible to rebase your changes automatically. Please merge master into your branch and try again.

[tschatzl]

This branch needed merging before integration, so needs a re-review. Nothing changed.

[tschatzl]

Thanks @albertnetymk @kimbarrett for your reviews

/integrate

[openjdk]

Going to push as commit a0dd565.

[openjdk]

@tschatzl Pushed as commit a0dd565.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.