-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8350668: has_extra_module_paths in filemap.cpp may be uninitialized #23780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8350668: has_extra_module_paths in filemap.cpp may be uninitialized #23780
Conversation
|
👋 Welcome back iklam! A progress list of the required criteria for merging this PR into |
|
@iklam This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
calvinccheung
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and trivial.
shipilev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine!
|
Thanks @calvinccheung @shipilev for the review |
|
Going to push as commit d422abc.
Your commit was automatically rebased without conflicts. |
Please review this trivial patch. The
has_extra_module_pathslocal variable should be initialized tofalse.Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23780/head:pull/23780$ git checkout pull/23780Update a local copy of the PR:
$ git checkout pull/23780$ git pull https://git.openjdk.org/jdk.git pull/23780/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 23780View PR using the GUI difftool:
$ git pr show -t 23780Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23780.diff
Using Webrev
Link to Webrev Comment