Skip to content

Conversation

@iklam
Copy link
Member

@iklam iklam commented Feb 25, 2025

Please review this trivial patch. The has_extra_module_paths local variable should be initialized to false.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8350668: has_extra_module_paths in filemap.cpp may be uninitialized (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23780/head:pull/23780
$ git checkout pull/23780

Update a local copy of the PR:
$ git checkout pull/23780
$ git pull https://git.openjdk.org/jdk.git pull/23780/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23780

View PR using the GUI difftool:
$ git pr show -t 23780

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23780.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 25, 2025

👋 Welcome back iklam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 25, 2025

@iklam This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8350668: has_extra_module_paths in filemap.cpp may be uninitialized

Reviewed-by: ccheung, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • dea7a9f: 8350516: Update model numbers for ECore-based cpus

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 25, 2025
@openjdk
Copy link

openjdk bot commented Feb 25, 2025

@iklam The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Feb 25, 2025
Copy link
Member

@calvinccheung calvinccheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and trivial.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 25, 2025
@mlbridge
Copy link

mlbridge bot commented Feb 25, 2025

Webrevs

Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine!

@iklam
Copy link
Member Author

iklam commented Feb 25, 2025

Thanks @calvinccheung @shipilev for the review
/integrate

@openjdk
Copy link

openjdk bot commented Feb 25, 2025

Going to push as commit d422abc.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 829d7a8: 8339889: Several compiler tests ignore vm flags and not marked as flagless
  • 0151b15: 8348367: Remove hotspot_not_fast_compiler and hotspot_slow_compiler test groups
  • c5992ca: 8349533: Refactor validator tests shell files to java
  • dea7a9f: 8350516: Update model numbers for ECore-based cpus

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 25, 2025
@openjdk openjdk bot closed this Feb 25, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 25, 2025
@openjdk
Copy link

openjdk bot commented Feb 25, 2025

@iklam Pushed as commit d422abc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants