8315488: Remove outdated and unused ciReplay support from SA

[coleenp]

This change removes the ci, c1 and c2 compiler code from the serviceability agent. The ciReplay functionality is supported inside the jvm and this duplicated functionality in SA had bit rotted so is removed.
Tested with tier1-4.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8315488: Remove outdated and unused ciReplay support from SA (Bug - P4)

Reviewers

• Vladimir Kozlov (@vnkozlov - Reviewer)
• Chris Plummer (@plummercj - Reviewer)
• Yudi Zheng (@mur47x111 - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23782/head:pull/23782
$ git checkout pull/23782

Update a local copy of the PR:
$ git checkout pull/23782
$ git pull https://git.openjdk.org/jdk.git pull/23782/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23782

View PR using the GUI difftool:
$ git pr show -t 23782

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23782.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8315488: Remove outdated and unused ciReplay support from SA

Reviewed-by: kvn, cjplummer, yzheng

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 87 new commits pushed to the master branch:

• 4109c73: 8349523: Unused runtime calls to drem/frem should be removed
• b054d24: 8350584: Check the usage of LOG_PLEASE
• 717c499: 8351014: ProblemList the com/sun/management/OperatingSystemMXBean cpuLoad tests on Windows
• 3657e92: 8349637: Integer.numberOfLeadingZeros outputs incorrectly in certain cases
• 93c8784: 8350716: [s390] intrinsify Thread.currentThread()
• d48ddfe: 8350748: VectorAPI: Method "checkMaskFromIndexSize" should be force inlined
• 0a1eea1: 8345492: Fix -Wzero-as-null-pointer-constant warnings in adlc code
• 157e5ad: 8350916: Remove misleading warning "Cannot dump shared archive while using shared archive"
• 785e7b4: 8350819: Ignore core files
• 3c72c04: 8350818: Improve OperatingSystemMXBean cpu load tests to not accept -1.0 by default
• ... and 77 more: https://git.openjdk.org/jdk/compare/65f79c145b7b1b32ed064a37ad4d2b6aca935a4c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@coleenp The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 06: Full - Incremental (38041d03)
• 05: Full - Incremental (aa80d2c6)
• 04: Full - Incremental (2d9ab884)
• 03: Full - Incremental (fca987a4)
• 02: Full - Incremental (fb673eb4)
• 01: Full - Incremental (0a86d6fe)
• 00: Full (8435f98b)

[coleenp]

/label add hotspot-compiler

[openjdk]

@coleenp
The hotspot-compiler label was successfully added.

[coleenp]

Thanks for looking at the change Chris and Vladimir.

With this change, we can further remove these VM_STRUCTS macros like declare_c1_type, declare_c1_toplevel_type, etc. It makes for a bigger change, but only more lines and more tedious.

[coleenp]

The os_cpu VM_STRUCTS, VM_TYPES, etc have no declarations and should be removed, but I think I should stop here.

[vnkozlov]

The os_cpu VM_STRUCTS, VM_TYPES, etc have no declarations and should be removed, but I think I should stop here.

File an other "starter" RFE

[vnkozlov]

Zero build is broken:

src/hotspot/share/runtime/vmStructs.cpp:1321:46: error: ‘COMPILER2’ was not declared in this scope; did you mean ‘NOT_COMPILER2’?
 1321 |   declare_preprocessor_constant("COMPILER2", COMPILER2)                   \
      |                                              ^~~~~~~~~

[vnkozlov]

Very very nice cleanup!

[plummercj]

I wonder if you shouldn't use a new CR for this PR to make it clear to anyone that skims over the title of the PR/CR that (broken) functionality is being removed, not fixed.

[vnkozlov]

I wonder if you shouldn't use a new CR for this PR to make it clear to anyone that skims over the title of the PR/CR that (broken) functionality is being removed, not fixed.

Just change title: "Remove outdated and unused ciReplay support from SA"

[coleenp]

I wonder if you shouldn't use a new CR for this PR to make it clear to anyone that skims over the title of the PR/CR that (broken) functionality is being removed, not fixed.

Just change title: "Remove outdated and unused ciReplay support from SA"

Yes, I'll do this.

[coleenp]

Thank you for reviewing Vladimir. I'll file the other issue but not a "starter". New people should do more interesting things :)

[mur47x111]

JVMCI changes LGTM

[coleenp]

Thank you for reviewing Chris, Vladimir and Yudi.
/integrate

[openjdk]

Going to push as commit 8b0468f.
Since your change was applied there have been 87 commits pushed to the master branch:

• 4109c73: 8349523: Unused runtime calls to drem/frem should be removed
• b054d24: 8350584: Check the usage of LOG_PLEASE
• 717c499: 8351014: ProblemList the com/sun/management/OperatingSystemMXBean cpuLoad tests on Windows
• 3657e92: 8349637: Integer.numberOfLeadingZeros outputs incorrectly in certain cases
• 93c8784: 8350716: [s390] intrinsify Thread.currentThread()
• d48ddfe: 8350748: VectorAPI: Method "checkMaskFromIndexSize" should be force inlined
• 0a1eea1: 8345492: Fix -Wzero-as-null-pointer-constant warnings in adlc code
• 157e5ad: 8350916: Remove misleading warning "Cannot dump shared archive while using shared archive"
• 785e7b4: 8350819: Ignore core files
• 3c72c04: 8350818: Improve OperatingSystemMXBean cpu load tests to not accept -1.0 by default
• ... and 77 more: https://git.openjdk.org/jdk/compare/65f79c145b7b1b32ed064a37ad4d2b6aca935a4c...master

Your commit was automatically rebased without conflicts.

[openjdk]

@coleenp Pushed as commit 8b0468f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.