8350682: [JMH] vector.IndexInRangeBenchmark failed with IndexOutOfBoundsException for size=1024

[IvaVladimir]

Array initialization by parameter was added. Extra constant was used to align cycle step with used arrays.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8350682: [JMH] vector.IndexInRangeBenchmark failed with IndexOutOfBoundsException for size=1024 (Enhancement - P4)

Reviewers

• Xiaohong Gong (@XiaohongGong - Committer)
• Derek White (@dwhite-intel - Committer)
• Sandhya Viswanathan (@sviswa7 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23783/head:pull/23783
$ git checkout pull/23783

Update a local copy of the PR:
$ git checkout pull/23783
$ git pull https://git.openjdk.org/jdk.git pull/23783/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23783

View PR using the GUI difftool:
$ git pr show -t 23783

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23783.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back vaivanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@IvaVladimir This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8350682: [JMH] vector.IndexInRangeBenchmark failed with IndexOutOfBoundsException for size=1024

Reviewed-by: xgong, drwhite, sviswanathan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 85 new commits pushed to the master branch:

• c4b516d: 8348322: AOT cache creation crashes with "All cached hidden classes must be aot-linkable" when AOTInvokeDynamicLinking is disabled
• e470f47: 8350095: RISC-V: Refactor string_compare
• f53de92: 8350931: RISC-V: remove unnecessary src register for fp_sqrt_d/f
• e1fc14f: 8350940: RISC-V: remove unnecessary assert_different_registers in minmax_fp
• 79880e5: 8351033: RISC-V: TestFloat16ScalarOperations asserts with offset (4210) is too large to be patched in one beq/bge/bgeu/blt/bltu/bne instruction!
• bb70896: 8350903: Remove explicit libjvm.so dependency for libVThreadEventTest
• 7c187b5: 8338737: Shenandoah: Reset marking bitmaps after the cycle
• 3602c8c: 8350955: Fix repetitions of the word "the" in runtime component comments
• c988d7d: 8350767: Fix -Wzero-as-null-pointer-constant warnings in nsk jni stress tests
• 67dfdfa: 8350623: Fix -Wzero-as-null-pointer-constant warnings in nsk native test utilities
• ... and 75 more: https://git.openjdk.org/jdk/compare/dea7a9f0d640e5234bafe2157aecd942c71d5de5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@XiaohongGong, @dwhite-intel, @sviswa7) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@IvaVladimir The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (6f345075)

[XiaohongGong]

Hi @IvaVladimir , thank you for fixing this benchmark. Could you please tell more information about the IOOBE crash (e.g. size, benchmark name, arch info, .etc) ? I still cannot figure out why it can fail with IOOBE. Thanks so much!

[XiaohongGong]

Hi @IvaVladimir , thank you for fixing this benchmark. Could you please tell more information about the IOOBE crash (e.g. size, benchmark name, arch info, .etc) ? I still cannot figure out why it can fail with IOOBE. Thanks so much!

I guess it happens when the parameter size is passed with a larger value than 512?

[IvaVladimir]

Yes, exceptions reported for runs with size=1024. The test support max size=512 and have no checks for passed params.

[XiaohongGong]

Yes, exceptions reported for runs with size=1024. The test support max size=512 and have no checks for passed params.

The change makes sense to me. Thanks for your fixing!

[sviswa7]

Any reason, for this to be "size + 64" instead of "size"?

[IvaVladimir]

This array iterated by steps from 8 to 64. If allocated array less than 64 it throws Exception.
Minimal array size is VectorSpecies for byte class. The constant was used instead of calculation.

[sviswa7]

Looks good to me.

[IvaVladimir]

/integrate

Thanks for your review!

[openjdk]

@IvaVladimir
Your change (at version 6f34507) is now ready to be sponsored by a Committer.

[dwhite-intel]

/sponsor

[openjdk]

Going to push as commit 768b024.
Since your change was applied there have been 85 commits pushed to the master branch:

• c4b516d: 8348322: AOT cache creation crashes with "All cached hidden classes must be aot-linkable" when AOTInvokeDynamicLinking is disabled
• e470f47: 8350095: RISC-V: Refactor string_compare
• f53de92: 8350931: RISC-V: remove unnecessary src register for fp_sqrt_d/f
• e1fc14f: 8350940: RISC-V: remove unnecessary assert_different_registers in minmax_fp
• 79880e5: 8351033: RISC-V: TestFloat16ScalarOperations asserts with offset (4210) is too large to be patched in one beq/bge/bgeu/blt/bltu/bne instruction!
• bb70896: 8350903: Remove explicit libjvm.so dependency for libVThreadEventTest
• 7c187b5: 8338737: Shenandoah: Reset marking bitmaps after the cycle
• 3602c8c: 8350955: Fix repetitions of the word "the" in runtime component comments
• c988d7d: 8350767: Fix -Wzero-as-null-pointer-constant warnings in nsk jni stress tests
• 67dfdfa: 8350623: Fix -Wzero-as-null-pointer-constant warnings in nsk native test utilities
• ... and 75 more: https://git.openjdk.org/jdk/compare/dea7a9f0d640e5234bafe2157aecd942c71d5de5...master

Your commit was automatically rebased without conflicts.

[openjdk]

@dwhite-intel @IvaVladimir Pushed as commit 768b024.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.