8350701: [JMH] test foreign.AllocFromSliceTest failed with Exception for size>1024

[IvaVladimir]

The 'size' parameters was used instead of hardcoded constant to improve support for different sizes.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8350701: [JMH] test foreign.AllocFromSliceTest failed with Exception for size>1024 (Enhancement - P4)

Reviewers

• Per Minborg (@minborg - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23785/head:pull/23785
$ git checkout pull/23785

Update a local copy of the PR:
$ git checkout pull/23785
$ git pull https://git.openjdk.org/jdk.git pull/23785/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23785

View PR using the GUI difftool:
$ git pr show -t 23785

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23785.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back vaivanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@IvaVladimir This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8350701: [JMH] test foreign.AllocFromSliceTest failed with Exception for size>1024

Reviewed-by: pminborg

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 45 new commits pushed to the master branch:

• 3ae80bf: 8349766: GenShen: Bad progress after degen does not always need full gc
• 2fd7156: 8347426: Invalid value used for enum Cell in iTypeFlow::StateVector::meet_exception
• 939815f: 8347040: C2: assert(!loop->_body.contains(in)) failed
• 8323ddf: 8346659: SnippetTaglet should report an error if provided ambiguous links
• 3c9d64e: 8350858: [IR Framework] Some tests failed on Cascade Lake
• d6d9447: 8350786: Some java/lang jtreg tests miss requires vm.hasJFR
• e80b76b: 8276995: Bug in jdk.jfr.event.gc.collection.TestSystemGC
• 799ac52: 8314840: 3 gc/epsilon tests ignore external vm options
• 63e0fc4: 8350841: ProblemList jdk/incubator/vector/Long256VectorTests.java
• acc6f19: 8350614: [JMH] jdk.incubator.vector.VectorCommutativeOperSharingBenchmark fails
• ... and 35 more: https://git.openjdk.org/jdk/compare/dea7a9f0d640e5234bafe2157aecd942c71d5de5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@minborg) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@IvaVladimir The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (b45da29c)

[minborg]

LGTM. The results of the benchmarks would be comparable with older benchmarks.

[IvaVladimir]

/integrate
Thanks for your review!

[openjdk]

@IvaVladimir
Your change (at version b45da29) is now ready to be sponsored by a Committer.

[dwhite-intel]

looks good!

/sponsor

[openjdk]

Going to push as commit f1398ec.
Since your change was applied there have been 45 commits pushed to the master branch:

• 3ae80bf: 8349766: GenShen: Bad progress after degen does not always need full gc
• 2fd7156: 8347426: Invalid value used for enum Cell in iTypeFlow::StateVector::meet_exception
• 939815f: 8347040: C2: assert(!loop->_body.contains(in)) failed
• 8323ddf: 8346659: SnippetTaglet should report an error if provided ambiguous links
• 3c9d64e: 8350858: [IR Framework] Some tests failed on Cascade Lake
• d6d9447: 8350786: Some java/lang jtreg tests miss requires vm.hasJFR
• e80b76b: 8276995: Bug in jdk.jfr.event.gc.collection.TestSystemGC
• 799ac52: 8314840: 3 gc/epsilon tests ignore external vm options
• 63e0fc4: 8350841: ProblemList jdk/incubator/vector/Long256VectorTests.java
• acc6f19: 8350614: [JMH] jdk.incubator.vector.VectorCommutativeOperSharingBenchmark fails
• ... and 35 more: https://git.openjdk.org/jdk/compare/dea7a9f0d640e5234bafe2157aecd942c71d5de5...master

Your commit was automatically rebased without conflicts.

[openjdk]

@dwhite-intel @IvaVladimir Pushed as commit f1398ec.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.