Skip to content

Conversation

@calvinccheung
Copy link
Member

@calvinccheung calvinccheung commented Feb 25, 2025

A fix for initializing the _timestamp field in AOTClassLocation properly so that the cmp-baseline builds are successful.

Sanity tested with builds-tier5.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8350666: cmp-baseline builds fail after JDK-8280682 (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23787/head:pull/23787
$ git checkout pull/23787

Update a local copy of the PR:
$ git checkout pull/23787
$ git pull https://git.openjdk.org/jdk.git pull/23787/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23787

View PR using the GUI difftool:
$ git pr show -t 23787

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23787.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 25, 2025

👋 Welcome back ccheung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 25, 2025

@calvinccheung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8350666: cmp-baseline builds fail after JDK-8280682

Reviewed-by: iklam

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • c8a521f: 8345213: JVM Prefers /etc/timezone Over /etc/localtime on Debian 12
  • 86024eb: 8348426: Generate binary file for -XX:AOTMode=record -XX:AOTConfiguration=file
  • 267d69b: 8326447: jpackage creates Windows installers that cannot be signed
  • 2efb033: 8350601: Miscellaneous updates to jpackage test lib

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Feb 25, 2025

@calvinccheung The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Feb 25, 2025
@calvinccheung calvinccheung marked this pull request as ready for review February 25, 2025 23:11
@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 25, 2025
Copy link
Member

@iklam iklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 25, 2025
@mlbridge
Copy link

mlbridge bot commented Feb 25, 2025

Webrevs

@iklam
Copy link
Member

iklam commented Feb 25, 2025

BTW I think this qualifies as a trivial fix. It reverts back to the same behavior before JDK-8280682.

@calvinccheung
Copy link
Member Author

Thanks @iklam for the quick review.

/integrate

@openjdk
Copy link

openjdk bot commented Feb 25, 2025

Going to push as commit c8bc416.
Since your change was applied there have been 4 commits pushed to the master branch:

  • c8a521f: 8345213: JVM Prefers /etc/timezone Over /etc/localtime on Debian 12
  • 86024eb: 8348426: Generate binary file for -XX:AOTMode=record -XX:AOTConfiguration=file
  • 267d69b: 8326447: jpackage creates Windows installers that cannot be signed
  • 2efb033: 8350601: Miscellaneous updates to jpackage test lib

Your commit was automatically rebased without conflicts.

@openjdk
Copy link

openjdk bot commented Feb 25, 2025

@calvinccheung An unexpected error occurred during integration. No push attempt will be made. The error has been logged and will be investigated. It is possible that this error is caused by a transient issue; feel free to retry the operation.

@calvinccheung
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Feb 25, 2025

Going to push as commit 037e471.
Since your change was applied there have been 4 commits pushed to the master branch:

  • c8a521f: 8345213: JVM Prefers /etc/timezone Over /etc/localtime on Debian 12
  • 86024eb: 8348426: Generate binary file for -XX:AOTMode=record -XX:AOTConfiguration=file
  • 267d69b: 8326447: jpackage creates Windows installers that cannot be signed
  • 2efb033: 8350601: Miscellaneous updates to jpackage test lib

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 25, 2025
@openjdk openjdk bot closed this Feb 25, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 25, 2025
@openjdk
Copy link

openjdk bot commented Feb 25, 2025

@calvinccheung Pushed as commit 037e471.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@calvinccheung calvinccheung deleted the 8350666-cmp-baseline-build branch February 25, 2025 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants