8350623: Fix -Wzero-as-null-pointer-constant warnings in nsk native test utilities

[kimbarrett]

Please review this trivial change to remove a use of literal zero as a null
pointer constant.

Testing: mach5 tier1
Locally tested (linux-x64) with -Wzero-as-null-pointer-constant enabled to
verify the warnings associated with this code were removed.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8350623: Fix -Wzero-as-null-pointer-constant warnings in nsk native test utilities (Enhancement - P4)

Reviewers

• Coleen Phillimore (@coleenp - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23797/head:pull/23797
$ git checkout pull/23797

Update a local copy of the PR:
$ git checkout pull/23797
$ git pull https://git.openjdk.org/jdk.git pull/23797/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23797

View PR using the GUI difftool:
$ git pr show -t 23797

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23797.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back kbarrett! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@kimbarrett This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8350623: Fix -Wzero-as-null-pointer-constant warnings in nsk native test utilities

Reviewed-by: coleenp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 62 new commits pushed to the master branch:

• db69ec9: 8344009: Improve compiler memory statistics
• f47232a: 8350954: Fix repetitions of the word "the" in gc component comments
• 30b0c60: 8350956: Fix repetitions of the word "the" in compiler component comments
• 8b0468f: 8315488: Remove outdated and unused ciReplay support from SA
• 4109c73: 8349523: Unused runtime calls to drem/frem should be removed
• b054d24: 8350584: Check the usage of LOG_PLEASE
• 717c499: 8351014: ProblemList the com/sun/management/OperatingSystemMXBean cpuLoad tests on Windows
• 3657e92: 8349637: Integer.numberOfLeadingZeros outputs incorrectly in certain cases
• 93c8784: 8350716: [s390] intrinsify Thread.currentThread()
• d48ddfe: 8350748: VectorAPI: Method "checkMaskFromIndexSize" should be force inlined
• ... and 52 more: https://git.openjdk.org/jdk/compare/037e47112bdf2fa2324f7c58198f6d433f17d9fd...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@kimbarrett The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (9182ce99)

[coleenp]

Looks good plus trivial.

[coleenp]

Lower case 'windows' ?? Not an issue for your change, but odd.

[kimbarrett]

Yeah, it's a bit odd. It's defined up at the top of the file, based on whether _WIN32 is defined. I've no
idea why _WIN32 isn't just used instead.

[kimbarrett]

Thanks for reviewing @coleenp

[kimbarrett]

/integrate

[openjdk]

Going to push as commit 67dfdfa.
Since your change was applied there have been 63 commits pushed to the master branch:

• 4a51c61: 8350567: NMT: update VMATree::register_mapping to copy the existing tag of the region
• db69ec9: 8344009: Improve compiler memory statistics
• f47232a: 8350954: Fix repetitions of the word "the" in gc component comments
• 30b0c60: 8350956: Fix repetitions of the word "the" in compiler component comments
• 8b0468f: 8315488: Remove outdated and unused ciReplay support from SA
• 4109c73: 8349523: Unused runtime calls to drem/frem should be removed
• b054d24: 8350584: Check the usage of LOG_PLEASE
• 717c499: 8351014: ProblemList the com/sun/management/OperatingSystemMXBean cpuLoad tests on Windows
• 3657e92: 8349637: Integer.numberOfLeadingZeros outputs incorrectly in certain cases
• 93c8784: 8350716: [s390] intrinsify Thread.currentThread()
• ... and 53 more: https://git.openjdk.org/jdk/compare/037e47112bdf2fa2324f7c58198f6d433f17d9fd...master

Your commit was automatically rebased without conflicts.

[openjdk]

@kimbarrett Pushed as commit 67dfdfa.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.