Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253342: Fix typos in String.transform #238

Closed
wants to merge 1 commit into from

Conversation

pavelrappo
Copy link
Member

@pavelrappo pavelrappo commented Sep 18, 2020

To confirm that this would not require a CSR I asked Joe Darcy. Joe replied that this would NOT require a CSR.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/238/head:pull/238
$ git checkout pull/238

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 18, 2020

👋 Welcome back prappo! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 18, 2020
@pavelrappo
Copy link
Member Author

/csr unneeded
/test tier1

@openjdk
Copy link

openjdk bot commented Sep 18, 2020

@pavelrappo The following label will be automatically applied to this pull request: core-libs.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Sep 18, 2020
@openjdk
Copy link

openjdk bot commented Sep 18, 2020

@pavelrappo determined that a CSR request is not needed for this pull request.

@pavelrappo
Copy link
Member Author

/test tier1

@mlbridge
Copy link

mlbridge bot commented Sep 18, 2020

Webrevs

* caller.
*
* @param f functional interface to a apply
* @param f a function to apply
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be "the function to apply"? Grep for other instance of "function to apply" in javadocs :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I grepped that before pushing and the results were inconclusive. For example, compare the below fragments from the same file:

    /**
...
     * @param mapper the mapping function to apply to each element
...
     */
    public static <T>
    Collector<T, ?, LongSummaryStatistics> summarizingLong(ToLongFunction<? super T> mapper)
    /**
...
     * @param mapper a mapping function to apply to each element
...
     */
    public static <T>
    Collector<T, ?, DoubleSummaryStatistics> summarizingDouble(ToDoubleFunction<? super T> mapper)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm! Better to defer to native speakers then...

Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the review from "Request Changes" to just "Comment.

@openjdk
Copy link

openjdk bot commented Sep 18, 2020

@pavelrappo This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8253342: Fix typos in String.transform

Reviewed-by: jlaskey
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 2 commits pushed to the master branch:

  • 86a1640: 8244505: G1 pause time ratio calculation does not consider Remark/Cleanup pauses
  • 11c4ea9: 8253278: Refactor/cleanup oopDesc::*_klass_addr

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 86a16400bd94d41c7961bf6dcac539c6a796dad3.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 18, 2020
@openjdk
Copy link

openjdk bot commented Sep 18, 2020

A test job has been started with id: github.com-149121954-238-694735632

@openjdk
Copy link

openjdk bot commented Sep 18, 2020

@pavelrappo your test job with id github.com-149121954-238-694735632 for commits up until 997284e has finished.

@pavelrappo
Copy link
Member Author

/integrate

@openjdk openjdk bot closed this Sep 18, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 18, 2020
@openjdk
Copy link

openjdk bot commented Sep 18, 2020

@pavelrappo Since your change was applied there have been 2 commits pushed to the master branch:

  • 86a1640: 8244505: G1 pause time ratio calculation does not consider Remark/Cleanup pauses
  • 11c4ea9: 8253278: Refactor/cleanup oopDesc::*_klass_addr

Your commit was automatically rebased without conflicts.

Pushed as commit 83b2411.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@pavelrappo pavelrappo deleted the 8253342 branch September 24, 2020 14:27
@pavelrappo pavelrappo restored the 8253342 branch October 9, 2020 08:46
@pavelrappo pavelrappo deleted the 8253342 branch October 9, 2020 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants