New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8253342: Fix typos in String.transform #238
Conversation
👋 Welcome back prappo! A progress list of the required criteria for merging this PR into |
/csr unneeded |
@pavelrappo The following label will be automatically applied to this pull request: When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the |
@pavelrappo determined that a CSR request is not needed for this pull request. |
/test tier1 |
* caller. | ||
* | ||
* @param f functional interface to a apply | ||
* @param f a function to apply |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be "the function to apply"? Grep for other instance of "function to apply" in javadocs :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I grepped that before pushing and the results were inconclusive. For example, compare the below fragments from the same file:
/**
...
* @param mapper the mapping function to apply to each element
...
*/
public static <T>
Collector<T, ?, LongSummaryStatistics> summarizingLong(ToLongFunction<? super T> mapper)
/**
...
* @param mapper a mapping function to apply to each element
...
*/
public static <T>
Collector<T, ?, DoubleSummaryStatistics> summarizingDouble(ToDoubleFunction<? super T> mapper)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm! Better to defer to native speakers then...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing the review from "Request Changes" to just "Comment.
@pavelrappo This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements After integration, the commit message will be:
Since the source branch of this PR was last updated there have been 2 commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge ➡️ To integrate this PR with the above commit message to the |
A test job has been started with id: github.com-149121954-238-694735632 |
@pavelrappo your test job with id github.com-149121954-238-694735632 for commits up until 997284e has finished. |
/integrate |
@pavelrappo Since your change was applied there have been 2 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 83b2411. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
To confirm that this would not require a CSR I asked Joe Darcy. Joe replied that this would NOT require a CSR.
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/238/head:pull/238
$ git checkout pull/238