8350824: New async logging gtest StallingModePreventsDroppedMessages fails

[jdksjolen]

Hi,

When I added async stalling mode I also added this gtest early in the process, and as tier1/GHA passed I did not look at the test again. However, the test does not run until much deeper in the CI/CD process for us, as that's when we turn on async logging explicitly for all gtests.

Looking at it now, it's clearly buggy. It doesn't check which async mode UL is in, and as drop is default, that makes it bound to fail. Besides, the goal of it is to check whether async stalling mode drops messages or not during stress. We already have an excellent test for that in JTReg, and this does run early as it spawns its own VM with the correct asynchronous mode specified. My suggested fix is to delete the gtest and add a dropped message check to the JTReg test instead.

Testing: StressAsyncUL.java, GHA

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8350824: New async logging gtest StallingModePreventsDroppedMessages fails (Bug - P3)

Reviewers

• Matthias Baesken (@MBaesken - Reviewer)
• David Holmes (@dholmes-ora - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23819/head:pull/23819
$ git checkout pull/23819

Update a local copy of the PR:
$ git checkout pull/23819
$ git pull https://git.openjdk.org/jdk.git pull/23819/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23819

View PR using the GUI difftool:
$ git pr show -t 23819

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23819.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jsjolen! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jdksjolen This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8350824: New async logging gtest StallingModePreventsDroppedMessages fails

Reviewed-by: mbaesken, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

• ab4b0ef: 8350889: GenShen: Break out of infinite loop of old GC cycles
• 0a4c5a8: 8347804: GenShen: Crash with small GCCardSizeInBytes and small Java heap
• f1398ec: 8350701: [JMH] test foreign.AllocFromSliceTest failed with Exception for size>1024
• 3ae80bf: 8349766: GenShen: Bad progress after degen does not always need full gc
• 2fd7156: 8347426: Invalid value used for enum Cell in iTypeFlow::StateVector::meet_exception
• 939815f: 8347040: C2: assert(!loop->_body.contains(in)) failed
• 8323ddf: 8346659: SnippetTaglet should report an error if provided ambiguous links
• 3c9d64e: 8350858: [IR Framework] Some tests failed on Cascade Lake
• d6d9447: 8350786: Some java/lang jtreg tests miss requires vm.hasJFR
• e80b76b: 8276995: Bug in jdk.jfr.event.gc.collection.TestSystemGC
• ... and 6 more: https://git.openjdk.org/jdk/compare/885338b5f38ed05d8b91efc0178b371f2f89310e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@jdksjolen The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (05792d0c)
• 00: Full (269b2261)

[jdksjolen]

Hi @MBaesken , @dholmes-ora

Would you mind reviewing this? Thank you!

[jdksjolen]

These tests do not currently fail, as the only mode gtests are run in are drop mode. However, let's fix them now in order to avoid failures in the future.

[dholmes-ora]

Seems okay.

Thanks

[jdksjolen]

Thank you

/integrate

[openjdk]

Going to push as commit ac76d8d.
Since your change was applied there have been 18 commits pushed to the master branch:

• eada1ea: 8350855: RISC-V: print offset by assert of patch_offset_in_conditional_branch
• 2af76de: 8350683: Non-C2 / minimal JVM crashes in the build on ppc64 platforms
• ab4b0ef: 8350889: GenShen: Break out of infinite loop of old GC cycles
• 0a4c5a8: 8347804: GenShen: Crash with small GCCardSizeInBytes and small Java heap
• f1398ec: 8350701: [JMH] test foreign.AllocFromSliceTest failed with Exception for size>1024
• 3ae80bf: 8349766: GenShen: Bad progress after degen does not always need full gc
• 2fd7156: 8347426: Invalid value used for enum Cell in iTypeFlow::StateVector::meet_exception
• 939815f: 8347040: C2: assert(!loop->_body.contains(in)) failed
• 8323ddf: 8346659: SnippetTaglet should report an error if provided ambiguous links
• 3c9d64e: 8350858: [IR Framework] Some tests failed on Cascade Lake
• ... and 8 more: https://git.openjdk.org/jdk/compare/885338b5f38ed05d8b91efc0178b371f2f89310e...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jdksjolen Pushed as commit ac76d8d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.