8350855: RISC-V: print offset by assert of patch_offset_in_conditional_branch

[Hamlin-Li]

HI,
Can you help to review this trivial patch?
We are facing the assert occasionally, but currently there is no offset info printed out, it's good to have it, as it's not easy to reproduce it.

Thanks

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8350855: RISC-V: print offset by assert of patch_offset_in_conditional_branch (Enhancement - P4)

Reviewers

• Fei Yang (@RealFYang - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23821/head:pull/23821
$ git checkout pull/23821

Update a local copy of the PR:
$ git checkout pull/23821
$ git pull https://git.openjdk.org/jdk.git pull/23821/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23821

View PR using the GUI difftool:
$ git pr show -t 23821

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23821.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@Hamlin-Li This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8350855: RISC-V: print offset by assert of patch_offset_in_conditional_branch

Reviewed-by: fyang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 81 new commits pushed to the master branch:

• 2af76de: 8350683: Non-C2 / minimal JVM crashes in the build on ppc64 platforms
• ab4b0ef: 8350889: GenShen: Break out of infinite loop of old GC cycles
• 0a4c5a8: 8347804: GenShen: Crash with small GCCardSizeInBytes and small Java heap
• f1398ec: 8350701: [JMH] test foreign.AllocFromSliceTest failed with Exception for size>1024
• 3ae80bf: 8349766: GenShen: Bad progress after degen does not always need full gc
• 2fd7156: 8347426: Invalid value used for enum Cell in iTypeFlow::StateVector::meet_exception
• 939815f: 8347040: C2: assert(!loop->_body.contains(in)) failed
• 8323ddf: 8346659: SnippetTaglet should report an error if provided ambiguous links
• 3c9d64e: 8350858: [IR Framework] Some tests failed on Cascade Lake
• d6d9447: 8350786: Some java/lang jtreg tests miss requires vm.hasJFR
• ... and 71 more: https://git.openjdk.org/jdk/compare/dfcd0df60c60cf89dc01682264a573ad39e61a17...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@Hamlin-Li The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (c574c248)

[Hamlin-Li]

Thank you!

[Hamlin-Li]

/integrate

[openjdk]

Going to push as commit eada1ea.
Since your change was applied there have been 81 commits pushed to the master branch:

• 2af76de: 8350683: Non-C2 / minimal JVM crashes in the build on ppc64 platforms
• ab4b0ef: 8350889: GenShen: Break out of infinite loop of old GC cycles
• 0a4c5a8: 8347804: GenShen: Crash with small GCCardSizeInBytes and small Java heap
• f1398ec: 8350701: [JMH] test foreign.AllocFromSliceTest failed with Exception for size>1024
• 3ae80bf: 8349766: GenShen: Bad progress after degen does not always need full gc
• 2fd7156: 8347426: Invalid value used for enum Cell in iTypeFlow::StateVector::meet_exception
• 939815f: 8347040: C2: assert(!loop->_body.contains(in)) failed
• 8323ddf: 8346659: SnippetTaglet should report an error if provided ambiguous links
• 3c9d64e: 8350858: [IR Framework] Some tests failed on Cascade Lake
• d6d9447: 8350786: Some java/lang jtreg tests miss requires vm.hasJFR
• ... and 71 more: https://git.openjdk.org/jdk/compare/dfcd0df60c60cf89dc01682264a573ad39e61a17...master

Your commit was automatically rebased without conflicts.

[openjdk]

@Hamlin-Li Pushed as commit eada1ea.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.