Skip to content

Conversation

@IvaVladimir
Copy link

@IvaVladimir IvaVladimir commented Feb 28, 2025

The scope was updated to support multithread configuration (jmh option '-t 2') . No other changes needed.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8350909: [JMH] test ThreadOnSpinWaitShared failed for 2 threads config (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23834/head:pull/23834
$ git checkout pull/23834

Update a local copy of the PR:
$ git checkout pull/23834
$ git pull https://git.openjdk.org/jdk.git pull/23834/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23834

View PR using the GUI difftool:
$ git pr show -t 23834

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23834.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 28, 2025

👋 Welcome back vaivanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 28, 2025

@IvaVladimir This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8350909: [JMH] test ThreadOnSpinWaitShared failed for 2 threads config

Reviewed-by: jbhateja, drwhite

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 145 new commits pushed to the master branch:

  • f6a8db2: 8348261: assert(n->is_Mem()) failed: memory node required
  • 5cd4fe6: 8348309: MultiNST tests need more debugging and timing
  • 7c22b81: 8350811: [JMH] test foreign.StrLenTest failed with StringIndexOutOfBoundsException for size=451
  • 54fe643: 8347433: Deprecate XML interchange in java.management/javax/management/modelmbean/DescriptorSupport for removal
  • 155697f: 8349623: [ASAN] Gtest os_linux.glibc_mallinfo_wrapper_vm fails
  • 4066f33: 8350565: NMT: remaining memory flag/type to be replaced with memory tag
  • 7314efc: 8351377: Fix the ProblemList for com/sun/management/OperatingSystemMXBean cpuLoad tests on AIX
  • 7c9a784: 8351223: Update localized resources in keytool and jarsigner
  • a23fb0a: 8348110: Update LCMS to 2.17
  • 0892913: 8351086: (fc) Make java/nio/channels/FileChannel/BlockDeviceSize.java test manual
  • ... and 135 more: https://git.openjdk.org/jdk/compare/dea7a9f0d640e5234bafe2157aecd942c71d5de5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jatin-bhateja, @dwhite-intel) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title JDK-8350909 [JMH] test ThreadOnSpinWaitShared failed for 2 threads config 8350909: [JMH] test ThreadOnSpinWaitShared failed for 2 threads config Feb 28, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 28, 2025
@openjdk
Copy link

openjdk bot commented Feb 28, 2025

@IvaVladimir The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Feb 28, 2025
@mlbridge
Copy link

mlbridge bot commented Feb 28, 2025

Webrevs

Copy link
Member

@jatin-bhateja jatin-bhateja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 6, 2025
@IvaVladimir
Copy link
Author

/integrate

Thanks for your review!

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 6, 2025
@openjdk
Copy link

openjdk bot commented Mar 6, 2025

@IvaVladimir
Your change (at version 2b70cd4) is now ready to be sponsored by a Committer.

Copy link

@dwhite-intel dwhite-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dwhite-intel
Copy link

/sponsor

@openjdk
Copy link

openjdk bot commented Mar 7, 2025

Going to push as commit 4e67ac4.
Since your change was applied there have been 146 commits pushed to the master branch:

  • 8ed6c1d: 8350607: Consolidate MethodHandles::zero into MethodHandles::constant
  • f6a8db2: 8348261: assert(n->is_Mem()) failed: memory node required
  • 5cd4fe6: 8348309: MultiNST tests need more debugging and timing
  • 7c22b81: 8350811: [JMH] test foreign.StrLenTest failed with StringIndexOutOfBoundsException for size=451
  • 54fe643: 8347433: Deprecate XML interchange in java.management/javax/management/modelmbean/DescriptorSupport for removal
  • 155697f: 8349623: [ASAN] Gtest os_linux.glibc_mallinfo_wrapper_vm fails
  • 4066f33: 8350565: NMT: remaining memory flag/type to be replaced with memory tag
  • 7314efc: 8351377: Fix the ProblemList for com/sun/management/OperatingSystemMXBean cpuLoad tests on AIX
  • 7c9a784: 8351223: Update localized resources in keytool and jarsigner
  • a23fb0a: 8348110: Update LCMS to 2.17
  • ... and 136 more: https://git.openjdk.org/jdk/compare/dea7a9f0d640e5234bafe2157aecd942c71d5de5...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 7, 2025
@openjdk openjdk bot closed this Mar 7, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Mar 7, 2025
@openjdk
Copy link

openjdk bot commented Mar 7, 2025

@dwhite-intel @IvaVladimir Pushed as commit 4e67ac4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants