8350940: RISC-V: remove unnecessary assert_different_registers in minmax_fp

[Hamlin-Li]

Hi,
Can you help to review this simple change?
Seems to me it's not necessary to assert_different_registers between dst/src1/src2 in minmax_fp.

Thanks

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8350940: RISC-V: remove unnecessary assert_different_registers in minmax_fp (Enhancement - P4)

Reviewers

• Fei Yang (@RealFYang - Reviewer)

Reviewers without OpenJDK IDs

• @abdelhak-zaaim (no known openjdk.org user name / role)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23842/head:pull/23842
$ git checkout pull/23842

Update a local copy of the PR:
$ git checkout pull/23842
$ git pull https://git.openjdk.org/jdk.git pull/23842/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23842

View PR using the GUI difftool:
$ git pr show -t 23842

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23842.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@Hamlin-Li This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8350940: RISC-V: remove unnecessary assert_different_registers in minmax_fp

Reviewed-by: fyang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• e98df71: 8348028: Unable to run gtests with CDS enabled
• d6c4be6: 8350758: G1: Use actual last prediction in accumulated survivor rate prediction too
• 2019f44: 8343832: Enhance test summary with number of skipped tests

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@Hamlin-Li this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout remove-unnecessary-reg-check
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

[openjdk]

@Hamlin-Li The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 03: Full - Incremental (a5d9782c)
• 02: Full - Incremental (f6fba6bf)
• 01: Full (e910c620)
• 00: Full (1aa9d892)

[Hamlin-Li]

Thank you!

[Hamlin-Li]

/integrate

[openjdk]

Going to push as commit e1fc14f.
Since your change was applied there have been 30 commits pushed to the master branch:

• 79880e5: 8351033: RISC-V: TestFloat16ScalarOperations asserts with offset (4210) is too large to be patched in one beq/bge/bgeu/blt/bltu/bne instruction!
• bb70896: 8350903: Remove explicit libjvm.so dependency for libVThreadEventTest
• 7c187b5: 8338737: Shenandoah: Reset marking bitmaps after the cycle
• 3602c8c: 8350955: Fix repetitions of the word "the" in runtime component comments
• c988d7d: 8350767: Fix -Wzero-as-null-pointer-constant warnings in nsk jni stress tests
• 67dfdfa: 8350623: Fix -Wzero-as-null-pointer-constant warnings in nsk native test utilities
• 4a51c61: 8350567: NMT: update VMATree::register_mapping to copy the existing tag of the region
• db69ec9: 8344009: Improve compiler memory statistics
• f47232a: 8350954: Fix repetitions of the word "the" in gc component comments
• 30b0c60: 8350956: Fix repetitions of the word "the" in compiler component comments
• ... and 20 more: https://git.openjdk.org/jdk/compare/ac76d8d63ff7b06a3c116559712a8b48f8acfa20...master

Your commit was automatically rebased without conflicts.

[openjdk]

@Hamlin-Li Pushed as commit e1fc14f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.