8350892: [JVMCI] Align ResolvedJavaType.getInstanceFields with Class.getDeclaredFields

[dougxc]

The current order of fields returned by ResolvedJavaType.getInstanceFields is a) not well specified and b) different than the order of fields used almost everywhere else in HotSpot. This PR aligns the order of getInstanceFields with Class.getDeclaredFields().

It also makes ciInstanceKlass::_nonstatic_fields use the same order which unifies how escape analysis and deoptimization treats fields across C2 and JVMCI.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8350892: [JVMCI] Align ResolvedJavaType.getInstanceFields with Class.getDeclaredFields (Enhancement - P4)

Reviewers

• Yudi Zheng (@mur47x111 - Committer)
• Tom Rodriguez (@tkrodriguez - Reviewer)
• Tobias Hartmann (@TobiHartmann - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23849/head:pull/23849
$ git checkout pull/23849

Update a local copy of the PR:
$ git checkout pull/23849
$ git pull https://git.openjdk.org/jdk.git pull/23849/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23849

View PR using the GUI difftool:
$ git pr show -t 23849

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23849.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dnsimon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dougxc This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8350892: [JVMCI] Align ResolvedJavaType.getInstanceFields with Class.getDeclaredFields

Reviewed-by: yzheng, never, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 361 new commits pushed to the master branch:

• 04eac0c: 8352159: RISC-V: add more zfa support
• ac760dd: 8352423: RISC-V: simplify DivI/L ModI/L
• d1cf232: 8352248: Check if CMoveX is supported
• 2b55979: 8352529: RISC-V: enable loopopts tests
• 8469458: 8352511: Show additional level of headings in table of contents
• 28250f8: 8352151: Fix display issues in javadoc-generated docs
• b32be18: 8352178: Add precondition in VMThread::execute to prevent deadlock
• 07667ca: 8352506: Simplify make/test/JtregNativeHotspot.gmk
• b545b9e: 8352584: [Backout] G1: Pinned regions with pinned objects only reachable by native code crash VM
• 1c0fa0a: 8352512: TestVectorZeroCount: counter not reset between iterations
• ... and 351 more: https://git.openjdk.org/jdk/compare/0131c1bfd8ccfdf4f3d73cddfc2a87e2a6e99581...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@dougxc The following labels will be automatically applied to this pull request:

• graal
• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (381af6ca)

[mur47x111]

Overall looks good to me

[mur47x111]

This has no effect now, i.e., the fields were sorted already?

[dougxc]

They now have whatever sort order is given by JavaFieldStream. This happens to currently be class file declaration order but it doesn't really matter if it changes. The only requirement is that the same order is used by get_reassigned_fields in deoptimization.cpp.

[tkrodriguez]

Seems like a good change.

[TobiHartmann]

Nice cleanup, CI changes look good to me.

[dougxc]

Thanks for the reviews!

/integrate

[openjdk]

Going to push as commit 0cb110e.
Since your change was applied there have been 361 commits pushed to the master branch:

• 04eac0c: 8352159: RISC-V: add more zfa support
• ac760dd: 8352423: RISC-V: simplify DivI/L ModI/L
• d1cf232: 8352248: Check if CMoveX is supported
• 2b55979: 8352529: RISC-V: enable loopopts tests
• 8469458: 8352511: Show additional level of headings in table of contents
• 28250f8: 8352151: Fix display issues in javadoc-generated docs
• b32be18: 8352178: Add precondition in VMThread::execute to prevent deadlock
• 07667ca: 8352506: Simplify make/test/JtregNativeHotspot.gmk
• b545b9e: 8352584: [Backout] G1: Pinned regions with pinned objects only reachable by native code crash VM
• 1c0fa0a: 8352512: TestVectorZeroCount: counter not reset between iterations
• ... and 351 more: https://git.openjdk.org/jdk/compare/0131c1bfd8ccfdf4f3d73cddfc2a87e2a6e99581...master

Your commit was automatically rebased without conflicts.

[openjdk]

@dougxc Pushed as commit 0cb110e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.