Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8271396: Spelling errors #2385

Closed
wants to merge 1 commit into from
Closed

8271396: Spelling errors #2385

wants to merge 1 commit into from

Conversation

@ebourg
Copy link
Contributor

@ebourg ebourg commented Feb 3, 2021

This PR fixes the following spelling errors:

choosen -> chosen
commad -> command
hiearchy -> hierarchy
leagacy -> legacy
minium -> minimum
subsytem -> subsystem
unamed -> unnamed


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/2385/head:pull/2385
$ git checkout pull/2385

Update a local copy of the PR:
$ git checkout pull/2385
$ git pull https://git.openjdk.java.net/jdk pull/2385/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2385

View PR using the GUI difftool:
$ git pr show -t 2385

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/2385.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 3, 2021

👋 Welcome back ebourg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Feb 3, 2021

@ebourg The following labels will be automatically applied to this pull request:

  • awt
  • core-libs
  • hotspot
  • net
  • serviceability
  • swing

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

Copy link
Contributor

@tschatzl tschatzl left a comment

Lgtm.

Copy link
Member

@ChrisHegarty ChrisHegarty left a comment

Trivially, looks ok to me.

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 21, 2021

@ebourg This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@ebourg
Copy link
Contributor Author

@ebourg ebourg commented Apr 21, 2021

.

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 19, 2021

@ebourg This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@ebourg
Copy link
Contributor Author

@ebourg ebourg commented Jun 7, 2021

.

@openjdk
Copy link

@openjdk openjdk bot commented Jun 7, 2021

@ebourg this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout typos
git fetch https://git.openjdk.java.net/jdk master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 5, 2021

@ebourg This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@kelthuzadx
Copy link
Member

@kelthuzadx kelthuzadx commented Jul 28, 2021

Hi, I've filed https://bugs.openjdk.java.net/browse/JDK-8271396 for this PR, you can change the title to "8271396: Spelling errors", openjdk bot will link this PR to the corresponding issue. Also you should resolve conflicts and pass jcheck before integrating it.

@ebourg ebourg changed the title Spelling errors 8271396: Spelling errors Jul 28, 2021
@ebourg
Copy link
Contributor Author

@ebourg ebourg commented Jul 28, 2021

Thank you!

@openjdk
Copy link

@openjdk openjdk bot commented Jul 28, 2021

@ebourg This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271396: Spelling errors

Reviewed-by: tschatzl, chegar, iris, psadhukhan, cjplummer

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

  • 489e5fd: 8268019: C2: assert(no_dead_loop) failed: dead loop detected
  • 6afcf5f: 8270886: Crash in PhaseIdealLoop::verify_strip_mined_scheduling
  • a0504cf: Merge
  • 20d2dc1: 8271403: mark hotspot runtime/memory tests which ignore external VM flags
  • e593e3d: 8271402: mark hotspot runtime/os tests which ignore external VM flags
  • 7bf72ce: 8271412: ProblemList javax/sound/midi/Sequencer/Looping.java
  • 6878b05: 8271251: JavaThread::java_suspend() fails with "fatal error: Illegal threadstate encountered: 6"
  • c8ae7e5: 8271174: runtime/ClassFile/UnsupportedClassFileVersion.java can be run in driver mode
  • 5fcf720: 8271352: Extend jcc erratum mitigation to additional processors
  • 6e1da64: 8270908: TestParallelRefProc fails on single core machines
  • ... and 8 more: https://git.openjdk.java.net/jdk/compare/a066c7bed0f9aa45fb9384f75ae84943548cd859...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@tschatzl, @ChrisHegarty, @irisclark, @prsadhuk, @plummercj) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@ebourg
Copy link
Contributor Author

@ebourg ebourg commented Jul 28, 2021

The PR has been updated

@ebourg
Copy link
Contributor Author

@ebourg ebourg commented Jul 28, 2021

/integrate

@openjdk openjdk bot added the sponsor label Jul 28, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 28, 2021

@ebourg
Your change (at version 31cfcba7eef6c5557f928f7285b4f9b5fdeff5ba) is now ready to be sponsored by a Committer.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 28, 2021

Webrevs

Copy link
Contributor

@prsadhuk prsadhuk left a comment

Thanks for awt/swing correction.

Copy link
Contributor

@plummercj plummercj left a comment

jdi, jvmti, and dcmd related changes look good.

@FrauBoes
Copy link
Member

@FrauBoes FrauBoes commented Jul 28, 2021

I'm happy to sponsor this change, but could you please update the copyright year where necessary, e.g. in
src/java.desktop/unix/classes/sun/awt/X11/XMSelection.java:
Copyright (c) 2003, 2018, Oracle... -> Copyright (c) 2003, 2021, Oracle...

 choosen  -> chosen
 commad   -> command
 hiearchy -> hierarchy
 leagacy  -> legacy
 minium   -> minimum
 subsytem -> subsystem
 unamed   -> unnamed
@ebourg
Copy link
Contributor Author

@ebourg ebourg commented Jul 28, 2021

@FrauBoes thank you, the PR has been updated to modify the copyright year

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Jul 28, 2021

@ebourg for future PRs please do not force push after the PR is out for review. Just push incremental commits normally. The Skara tooling will squash them all into a single commit.

@ebourg
Copy link
Contributor Author

@ebourg ebourg commented Jul 28, 2021

@kevinrushforth I'll do that, thank you for the hint

@FrauBoes
Copy link
Member

@FrauBoes FrauBoes commented Jul 29, 2021

@ebourg Thanks for updating the copyright. If you integrate again, I can sponsor.

@ebourg
Copy link
Contributor Author

@ebourg ebourg commented Jul 29, 2021

/integrate

@openjdk openjdk bot added the sponsor label Jul 29, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 29, 2021

@ebourg
Your change (at version 6e1be4f) is now ready to be sponsored by a Committer.

@FrauBoes
Copy link
Member

@FrauBoes FrauBoes commented Jul 29, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Jul 29, 2021

Going to push as commit d09b028.
Since your change was applied there have been 18 commits pushed to the master branch:

  • 489e5fd: 8268019: C2: assert(no_dead_loop) failed: dead loop detected
  • 6afcf5f: 8270886: Crash in PhaseIdealLoop::verify_strip_mined_scheduling
  • a0504cf: Merge
  • 20d2dc1: 8271403: mark hotspot runtime/memory tests which ignore external VM flags
  • e593e3d: 8271402: mark hotspot runtime/os tests which ignore external VM flags
  • 7bf72ce: 8271412: ProblemList javax/sound/midi/Sequencer/Looping.java
  • 6878b05: 8271251: JavaThread::java_suspend() fails with "fatal error: Illegal threadstate encountered: 6"
  • c8ae7e5: 8271174: runtime/ClassFile/UnsupportedClassFileVersion.java can be run in driver mode
  • 5fcf720: 8271352: Extend jcc erratum mitigation to additional processors
  • 6e1da64: 8270908: TestParallelRefProc fails on single core machines
  • ... and 8 more: https://git.openjdk.java.net/jdk/compare/a066c7bed0f9aa45fb9384f75ae84943548cd859...master

Your commit was automatically rebased without conflicts.

@openjdk
Copy link

@openjdk openjdk bot commented Jul 29, 2021

@FrauBoes @ebourg Pushed as commit d09b028.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@ebourg
Copy link
Contributor Author

@ebourg ebourg commented Jul 29, 2021

Thank you, glad to land my first commit to OpenJDK

@ebourg ebourg deleted the typos branch Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment