8350974: The os_cpu VM_STRUCTS, VM_TYPES, etc have no declarations and should be removed

[coleenp]

This is a trivial change to remove unused SA os_cpu declarations and files.
Tested with serviceability/sa tests locally.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8350974: The os_cpu VM_STRUCTS, VM_TYPES, etc have no declarations and should be removed (Enhancement - P4)

Reviewers

• Vladimir Kozlov (@vnkozlov - Reviewer)
• David Holmes (@dholmes-ora - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23863/head:pull/23863
$ git checkout pull/23863

Update a local copy of the PR:
$ git checkout pull/23863
$ git pull https://git.openjdk.org/jdk.git pull/23863/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23863

View PR using the GUI difftool:
$ git pr show -t 23863

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23863.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8350974: The os_cpu VM_STRUCTS, VM_TYPES, etc have no declarations and should be removed

Reviewed-by: kvn, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

• 4fc72b8: 8351082: Remove dead code for estimating CDS archive size
• b6e2d66: 8351087: Combine scratch object tables in heapShared.cpp
• d9b98f7: 8350771: Fix -Wzero-as-null-pointer-constant warning in nsk/monitoring ThreadController utility
• 7c173fd: 8351077: Shenandoah: Update comments in ShenandoahConcurrentGC::op_reset_after_collect
• 96613cc: 8349516: StAXStream2SAX.handleCharacters() fails on empty CDATA
• 3a8a432: 8349094: GenShen: Race between control and regulator threads may violate assertions
• 99fb350: 8350654: (fs) Files.createTempDirectory should say something about the default file permissions when no file attributes specified
• 768b024: 8350682: [JMH] vector.IndexInRangeBenchmark failed with IndexOutOfBoundsException for size=1024
• c4b516d: 8348322: AOT cache creation crashes with "All cached hidden classes must be aot-linkable" when AOTInvokeDynamicLinking is disabled
• e470f47: 8350095: RISC-V: Refactor string_compare
• ... and 11 more: https://git.openjdk.org/jdk/compare/30b0c6098028cce63e65bd9d563973f2774fa74d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@coleenp The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (bfb0a781)

[coleenp]

I didn't see email for this PR (?)

[vnkozlov]

I didn't see email for this PR (?)

Me too. But your comment generated e-mail.

[vnkozlov]

Good.

[coleenp]

Thanks Vladimir. I guess the email bot for hotspot-runtime was down this morning.

[dholmes-ora]

Looks like a nice cleanup. Just hope we won't need it back sometime.

Thanks

[coleenp]

I hope we don't need it back either. It seems like that would be a mistake.
Thanks for reviewing Vladimir and David.
/integrate

[openjdk]

Going to push as commit 8073914.
Since your change was applied there have been 24 commits pushed to the master branch:

• 7ee89a5: 8350893: Use generated names for hand generated opto runtime blobs
• fae37aa: 8345627: [REDO] Use gcc12 -ftrivial-auto-var-init=pattern in debug builds
• 1f10ffb: 8350851: ZGC: Reduce size of ZAddressOffsetMax scaling data structures
• 4fc72b8: 8351082: Remove dead code for estimating CDS archive size
• b6e2d66: 8351087: Combine scratch object tables in heapShared.cpp
• d9b98f7: 8350771: Fix -Wzero-as-null-pointer-constant warning in nsk/monitoring ThreadController utility
• 7c173fd: 8351077: Shenandoah: Update comments in ShenandoahConcurrentGC::op_reset_after_collect
• 96613cc: 8349516: StAXStream2SAX.handleCharacters() fails on empty CDATA
• 3a8a432: 8349094: GenShen: Race between control and regulator threads may violate assertions
• 99fb350: 8350654: (fs) Files.createTempDirectory should say something about the default file permissions when no file attributes specified
• ... and 14 more: https://git.openjdk.org/jdk/compare/30b0c6098028cce63e65bd9d563973f2774fa74d...master

Your commit was automatically rebased without conflicts.

[openjdk]

@coleenp Pushed as commit 8073914.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.