Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8260664: Phaser.arrive() memory consistency effects #2388

Closed
wants to merge 1 commit into from

Conversation

@Martin-Buchholz
Copy link
Member

@Martin-Buchholz Martin-Buchholz commented Feb 3, 2021

/cc core-libs


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8260664: Phaser.arrive() memory consistency effects

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2388/head:pull/2388
$ git checkout pull/2388

@Martin-Buchholz
Copy link
Member Author

@Martin-Buchholz Martin-Buchholz commented Feb 3, 2021

/issue add JDK-8260664

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 3, 2021

👋 Welcome back martin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the core-libs label Feb 3, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 3, 2021

@Martin-Buchholz
The core-libs label was successfully added.

@openjdk
Copy link

@openjdk openjdk bot commented Feb 3, 2021

@Martin-Buchholz This issue is referenced in the PR title - it will now be updated.

@Martin-Buchholz Martin-Buchholz marked this pull request as ready for review Feb 3, 2021
@openjdk openjdk bot added the rfr label Feb 3, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 3, 2021

Webrevs

@Martin-Buchholz
Copy link
Member Author

@Martin-Buchholz Martin-Buchholz commented Feb 3, 2021

DougLea
DougLea approved these changes Feb 3, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 3, 2021

@Martin-Buchholz This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8260664: Phaser.arrive() memory consistency effects

Reviewed-by: dl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 2be60e3: 8257988: Remove JNF dependency from libsaproc/MacosxDebuggerLocal.m

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 3, 2021
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 3, 2021

@Martin-Buchholz This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@Martin-Buchholz
Copy link
Member Author

@Martin-Buchholz Martin-Buchholz commented Mar 8, 2021

/integrate

@openjdk openjdk bot closed this Mar 8, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Mar 8, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 8, 2021

@Martin-Buchholz Since your change was applied there have been 430 commits pushed to the master branch:

  • 9221540: 8213269: convert test/hotspot/jtreg/runtime/memory/RunUnitTestsConcurrently to gtest
  • 17853ee: 8263200: Add -XX:StressCCP to CTW
  • a2b8858: 8263041: Shenandoah: Cleanup C1 keep alive barrier check
  • 1f9ed90: 8219555: compiler/jvmci/compilerToVM/IsMatureTest.java fails with Unexpected isMature state for multiple times invoked method: expected false to equal true
  • bf9b74d: 8262446: DragAndDrop hangs on Windows
  • b1cc864: 8251210: Link JDK api docs to other versions
  • 0da889e: 8210100: ParallelGC should use parallel WeakProcessor
  • 679faa6: 8263097: Update JMH devkit to 1.28
  • ab2cfcc: 8252831: Correct "no comment" warnings in jdk.net module
  • 51cca57: 8259577: Dangling reference to temp_path in Java_sun_tools_attach_VirtualMachineImpl_getTempDir
  • ... and 420 more: https://git.openjdk.java.net/jdk/compare/f025bc1d5d81532a3bdb87665537de4aaf15b7ea...master

Your commit was automatically rebased without conflicts.

Pushed as commit eb4a8af.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants