8351115: Test AOTClassLinkingVMOptions.java fails after JDK-8348322

[sendaoYan]

Hi all,

Test runtime/cds/appcds/aotClassLinking/AOTClassLinkingVMOptions.java fails "VM option 'AOTInvokeDynamicLinking' is diagnostic and must be enabled via -XX:+UnlockDiagnosticVMOptions" after JDK-8348322. This PR add JVM option '-XX:+UnlockDiagnosticVMOptions' to make test run passes.

Change has been verified locally, test-fix only, no risk.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8351115: Test AOTClassLinkingVMOptions.java fails after JDK-8348322 (Bug - P3)

Reviewers

• David Holmes (@dholmes-ora - Reviewer)
• Ioi Lam (@iklam - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23883/head:pull/23883
$ git checkout pull/23883

Update a local copy of the PR:
$ git checkout pull/23883
$ git pull https://git.openjdk.org/jdk.git pull/23883/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23883

View PR using the GUI difftool:
$ git pr show -t 23883

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23883.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8351115: Test AOTClassLinkingVMOptions.java fails after JDK-8348322

Reviewed-by: dholmes, iklam

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

• 6a31aae: 8350594: Misleading warning about install dir for DMG packaging
• 216f113: 8344892: beans/finder/MethodFinder.findMethod incorrectly returns null
• 3230894: 8348561: Add aarch64 intrinsics for ML-DSA
• 8073914: 8350974: The os_cpu VM_STRUCTS, VM_TYPES, etc have no declarations and should be removed
• 7ee89a5: 8350893: Use generated names for hand generated opto runtime blobs
• fae37aa: 8345627: [REDO] Use gcc12 -ftrivial-auto-var-init=pattern in debug builds
• 1f10ffb: 8350851: ZGC: Reduce size of ZAddressOffsetMax scaling data structures

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@sendaoYan The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (c049ab08)

[dholmes-ora]

Looks good and trivial.

Thanks

[iklam]

LGTM

[sendaoYan]

Thanks all for the reviews.

/integrate

[openjdk]

Going to push as commit 062b7c7.
Since your change was applied there have been 23 commits pushed to the master branch:

• a88e8cd: 8350952: Remove some non present files from OPT_SPEED_SRC list
• de29ef3: 8343191: Cgroup v1 subsystem fails to set subsystem path
• 75f028b: 8348657: compiler/loopopts/superword/TestEquivalentInvariants.java timed out
• b1a21b5: 8351101: RISC-V: C2: Small improvement to MacroAssembler::revb
• 62fa33a: 8351158: Incorrect APX EGPR register save ordering
• 20ea218: 8336042: Caller/callee param size mismatch in deoptimization causes crash
• 38b4d46: 8351081: Off-by-one error in ShenandoahCardCluster
• 29de20d: 8280991: [XWayland] No displayChanged event after setDisplayMode call
• 3e86b3a: 8350013: Add a test for JDK-8150442
• a21302b: 8351036: [JVMCI] value not an s2: -32776
• ... and 13 more: https://git.openjdk.org/jdk/compare/4fc72b8e4b22db2aa3217afb5b8c30d496589eb8...master

Your commit was automatically rebased without conflicts.

[openjdk]

@sendaoYan Pushed as commit 062b7c7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.