8351036: [JVMCI] value not an s2: -32776

[dougxc]

This PR adds support for JVMCI to install code that requires stack slots whose offset > Short.MAX_VALUE.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8351036: [JVMCI] value not an s2: -32776 (Bug - P4)

Reviewers

• Yudi Zheng (@mur47x111 - Committer)
• Dean Long (@dean-long - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23888/head:pull/23888
$ git checkout pull/23888

Update a local copy of the PR:
$ git checkout pull/23888
$ git pull https://git.openjdk.org/jdk.git pull/23888/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23888

View PR using the GUI difftool:
$ git pr show -t 23888

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23888.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dnsimon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dougxc This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8351036: [JVMCI] value not an s2: -32776

Reviewed-by: yzheng, dlong

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 154 new commits pushed to the master branch:

• 5598792: 8351064: JFR: Consistent timestamps
• fe806ca: 8350605: assert(!heap->is_uncommit_in_progress()) failed: Cannot uncommit bitmaps while resetting them
• 5b8d349: 4745837: Make grouping usage during parsing apparent in relevant NumberFormat methods
• 4aa4b46: 8351154: Use -ftrivial-auto-var-init=pattern for clang too
• daf0213: 8350924: javax/swing/JMenu/4213634/bug4213634.java fails
• 6a31aae: 8350594: Misleading warning about install dir for DMG packaging
• 216f113: 8344892: beans/finder/MethodFinder.findMethod incorrectly returns null
• 3230894: 8348561: Add aarch64 intrinsics for ML-DSA
• 8073914: 8350974: The os_cpu VM_STRUCTS, VM_TYPES, etc have no declarations and should be removed
• 7ee89a5: 8350893: Use generated names for hand generated opto runtime blobs
• ... and 144 more: https://git.openjdk.org/jdk/compare/0131c1bfd8ccfdf4f3d73cddfc2a87e2a6e99581...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@dougxc The following labels will be automatically applied to this pull request:

• graal
• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (8c429808)

[dougxc]

Thanks for the reviews!

/integrate

[openjdk]

Going to push as commit a21302b.
Since your change was applied there have been 155 commits pushed to the master branch:

• 0753376: 8297531: sun/security/krb5/MicroTime.java fails with "Exception: What? only 100 musec precision?"
• 5598792: 8351064: JFR: Consistent timestamps
• fe806ca: 8350605: assert(!heap->is_uncommit_in_progress()) failed: Cannot uncommit bitmaps while resetting them
• 5b8d349: 4745837: Make grouping usage during parsing apparent in relevant NumberFormat methods
• 4aa4b46: 8351154: Use -ftrivial-auto-var-init=pattern for clang too
• daf0213: 8350924: javax/swing/JMenu/4213634/bug4213634.java fails
• 6a31aae: 8350594: Misleading warning about install dir for DMG packaging
• 216f113: 8344892: beans/finder/MethodFinder.findMethod incorrectly returns null
• 3230894: 8348561: Add aarch64 intrinsics for ML-DSA
• 8073914: 8350974: The os_cpu VM_STRUCTS, VM_TYPES, etc have no declarations and should be removed
• ... and 145 more: https://git.openjdk.org/jdk/compare/0131c1bfd8ccfdf4f3d73cddfc2a87e2a6e99581...master

Your commit was automatically rebased without conflicts.

[openjdk]

@dougxc Pushed as commit a21302b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.