Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8260221: java.util.Formatter throws wrong exception for mismatched flags in %% conversion #2389

Closed
wants to merge 1 commit into from

Conversation

igraves
Copy link
Member

@igraves igraves commented Feb 3, 2021

Updating the specification to reflect well-established behavior in Formatter when incorrect flags used for %.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8260221: java.util.Formatter throws wrong exception for mismatched flags in %% conversion

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2389/head:pull/2389
$ git checkout pull/2389

@igraves
Copy link
Member Author

@igraves igraves commented Feb 3, 2021

/csr

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 3, 2021

👋 Welcome back igraves! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added rfr csr labels Feb 3, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 3, 2021

@igraves has indicated that a compatibility and specification (CSR) request is needed for this pull request.
@igraves please create a CSR request and add link to it in JDK-8261004. This pull request cannot be integrated until the CSR request is approved.

@openjdk
Copy link

@openjdk openjdk bot commented Feb 3, 2021

@igraves The following labels will be automatically applied to this pull request:

  • core-libs
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added core-libs i18n labels Feb 3, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 3, 2021

Webrevs

@igraves igraves changed the title 8261004: java.util.Formatter throws wrong exception for mismatched flags in %% conversion 8260221: java.util.Formatter throws wrong exception for mismatched flags in %% conversion Feb 4, 2021
@openjdk openjdk bot removed the csr label Feb 4, 2021
@igraves
Copy link
Member Author

@igraves igraves commented Feb 9, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Feb 9, 2021

@igraves This PR has not yet been marked as ready for integration.

@openjdk
Copy link

@openjdk openjdk bot commented Feb 12, 2021

@igraves This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8260221: java.util.Formatter throws wrong exception for mismatched flags in %% conversion

Reviewed-by: smarks

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 175 new commits pushed to the master branch:

  • 40ae993: 8261027: AArch64: Support for LSE atomics C++ HotSpot code
  • 9ffabf3: 8252971: WindowsFileAttributes does not know about Unix domain sockets
  • 682e78e: 8261071: AArch64: Refactor interpreter native wrappers
  • ebaa58d: 8261505: Test test/hotspot/jtreg/gc/parallel/TestDynShrinkHeap.java killed by Linux OOM Killer
  • 3210095: 8261079: Fix support for @hidden in classes and interfaces
  • 9c0ec8d: 8260941: Remove the conc_scan parameter for CardTable
  • da9895a: 8261499: Simplify HTML for javadoc links
  • 0779add: 8255059: Regressions >5% in all Javadoc benchmarks in 16-b19
  • 6a84ec6: 8260044: Parallel GC: Concurrent allocation after heap expansion may cause unnecessary full gc
  • 92ff891: 8261593: Do not use NULL pointer as write buffer parameter in jfrEmergencyDump.cpp write_repository_files
  • ... and 165 more: https://git.openjdk.java.net/jdk/compare/02d586e13edcdf6be03b15e9416cc63b6ea1c8c1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@stuart-marks) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Feb 12, 2021
@igraves
Copy link
Member Author

@igraves igraves commented Feb 12, 2021

/integrate

@openjdk openjdk bot added the sponsor label Feb 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 12, 2021

@igraves
Your change (at version c95d501) is now ready to be sponsored by a Committer.

@stuart-marks
Copy link
Member

@stuart-marks stuart-marks commented Feb 12, 2021

/sponsor

@openjdk openjdk bot closed this Feb 12, 2021
@openjdk openjdk bot added integrated and removed sponsor ready rfr labels Feb 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 12, 2021

@stuart-marks @igraves Since your change was applied there have been 180 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit 350303d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs i18n integrated
2 participants