8219408: Tests should handle ${} in the view of jtreg "smart action"

[mpdonova]

In this PR I removed TEST.properties files that disabled smart action tags. It is safe to remove the entire file: the smart action tags was the only directive in them. I verified the affected tests pass successfully.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8219408: Tests should handle ${} in the view of jtreg "smart action" (Enhancement - P4)

Reviewers

• Sean Mullan (@seanjmullan - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23896/head:pull/23896
$ git checkout pull/23896

Update a local copy of the PR:
$ git checkout pull/23896
$ git pull https://git.openjdk.org/jdk.git pull/23896/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23896

View PR using the GUI difftool:
$ git pr show -t 23896

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23896.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mdonovan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mpdonova This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8219408: Tests should handle ${} in the view of jtreg "smart action"

Reviewed-by: mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 429 new commits pushed to the master branch:

• b428cda: 8349686: [s390x] C1: Improve Class.isInstance intrinsic
• 70e3250: 8352419: Test tools/jpackage/share/ErrorTest.java#id0 and #id1 fail
• 296d9d6: 8353345: C2 asserts because maskShiftAmount modifies node without deleting the hash
• 3ceabf0: 8353359: C2: Or(I|L)Node::Ideal is missing AddNode::Ideal call
• b263292: 8353484: JFR: Simplify EventConfiguration
• ffca4f2: 8353264: ZGC: Windows heap unreserving is broken
• f7a94fe: 8352585: Add special case handling for Float16.max/min x86 backend
• 9c5ed23: 8349988: Change cgroup version detection logic to not depend on /proc/cgroups
• 00a038e: 8353341: C2: removal of a Mod[DF]Node crashes when the node is already dead
• bd74922: 8338675: javac shouldn't silently change .jar files on the classpath
• ... and 419 more: https://git.openjdk.org/jdk/compare/e470f474ee2176eecc211ec8e99cccc941104c68...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@mpdonova The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (5874b87e)

[myankelev]

Looks good to me 👍

[seanjmullan]

Looks ok, but I am wondering ... how did these tests pass in the first place if the allowSmartActionArgs property was false?

[mpdonova]

Looks ok, but I am wondering ... how did these tests pass in the first place if the allowSmartActionArgs property was false?

The underlying code uses PropertyExpander.expand() which looks for and expands ${} values.

[mpdonova]

/integrate

[openjdk]

Going to push as commit 353e173.
Since your change was applied there have been 468 commits pushed to the master branch:

• 26bb183: 8352621: MatchException from backwards incompatible change to switch expressions
• e8c9e5c: 8353231: Test com/sun/management/OperatingSystemMXBean/GetProcessCpuLoad still fails intermittently
• 6ab1647: 8353637: ZGC: Discontiguous memory reservation is broken on Windows
• c494a00: 8353559: Restructure CollectedHeap error printing
• 32d6d03: 8349348: Refactor ClassLoaderDeadlock.sh and Deadlock.sh to run fully in java
• 39549f8: 8352116: Deadlock with GCLocker and JVMTI after JDK-8192647
• d63b561: 8353188: C1: Clean up x86 backend after 32-bit x86 removal
• d1e91fc: 8353344: RISC-V: Detect and enable several extensions for debug builds
• 6abf4e6: 8353568: SEGV_BNDERR signal code adjust definition
• 6d9ece7: 8351949: RISC-V: Cleanup and enable store-load peephole for membars
• ... and 458 more: https://git.openjdk.org/jdk/compare/e470f474ee2176eecc211ec8e99cccc941104c68...master

Your commit was automatically rebased without conflicts.

[openjdk]

@mpdonova Pushed as commit 353e173.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.