8351165: Remove unused includes from vmStructs

[coleenp]

Please review this trivial change to remove some unneeded includes and type declarations from vmStructs. The SystemDictionary type is unused because classes are looked up in the ClassLoaderDataGraph in the SA, and they haven't been in a single SystemDictionary for a very long time.
Tested with SA tests locally.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8351165: Remove unused includes from vmStructs (Enhancement - P4)

Reviewers

• Kim Barrett (@kimbarrett - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23897/head:pull/23897
$ git checkout pull/23897

Update a local copy of the PR:
$ git checkout pull/23897
$ git pull https://git.openjdk.org/jdk.git pull/23897/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23897

View PR using the GUI difftool:
$ git pr show -t 23897

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23897.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8351165: Remove unused includes from vmStructs

Reviewed-by: kbarrett

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 26 new commits pushed to the master branch:

• c3b4819: 8351074: Disallow null prefix and suffix in DecimalFormat
• 6012e8d: 8350808: Small typos in JShell method SnippetEvent.toString()
• 661bd5b: 8343478: Remove unnecessary @SuppressWarnings annotations (core-libs)
• 61d9ab9: 8350854: Include thread counts in safepoint logging
• ea9e3cf: 8281511: java/net/ipv6tests/UdpTest.java fails with checkTime failed
• caaf409: 8350546: Several java/net/InetAddress tests fails UnknownHostException
• 062b7c7: 8351115: Test AOTClassLinkingVMOptions.java fails after JDK-8348322
• a88e8cd: 8350952: Remove some non present files from OPT_SPEED_SRC list
• de29ef3: 8343191: Cgroup v1 subsystem fails to set subsystem path
• 75f028b: 8348657: compiler/loopopts/superword/TestEquivalentInvariants.java timed out
• ... and 16 more: https://git.openjdk.org/jdk/compare/8073914af7d4ddd7bbd93d75104c7637e38a7ad9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@coleenp The following labels will be automatically applied to this pull request:

• hotspot-runtime
• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 04: Full - Incremental (b51cf0fd)
• 03: Full - Incremental (f2bb9364)
• 02: Full - Incremental (86443005)
• 01: Full - Incremental (e33d5066)
• 00: Full (c66907b6)

[kimbarrett]

I think that if classes are being removed from here that the friendship with
VMStructs by those classes should also be removed.

[coleenp]

I think that if classes are being removed from here that the friendship with
VMStructs by those classes should also be removed.

Good point. Thanks for remembering these.

[kimbarrett]

Looks good.

[coleenp]

Thanks Kim. I'm going to continue to claim this is trivial.
/integrate

[openjdk]

Going to push as commit 11a37c8.
Since your change was applied there have been 26 commits pushed to the master branch:

• c3b4819: 8351074: Disallow null prefix and suffix in DecimalFormat
• 6012e8d: 8350808: Small typos in JShell method SnippetEvent.toString()
• 661bd5b: 8343478: Remove unnecessary @SuppressWarnings annotations (core-libs)
• 61d9ab9: 8350854: Include thread counts in safepoint logging
• ea9e3cf: 8281511: java/net/ipv6tests/UdpTest.java fails with checkTime failed
• caaf409: 8350546: Several java/net/InetAddress tests fails UnknownHostException
• 062b7c7: 8351115: Test AOTClassLinkingVMOptions.java fails after JDK-8348322
• a88e8cd: 8350952: Remove some non present files from OPT_SPEED_SRC list
• de29ef3: 8343191: Cgroup v1 subsystem fails to set subsystem path
• 75f028b: 8348657: compiler/loopopts/superword/TestEquivalentInvariants.java timed out
• ... and 16 more: https://git.openjdk.org/jdk/compare/8073914af7d4ddd7bbd93d75104c7637e38a7ad9...master

Your commit was automatically rebased without conflicts.

[openjdk]

@coleenp Pushed as commit 11a37c8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.