New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8253235: JFR.dump does not respect maxage parameter #239
Conversation
|
@kvergizova The following label will be automatically applied to this pull request: When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the |
Mailing list message from Ekaterina Vergizova on hotspot-jfr-dev: Gentle reminder -----Original Message----- JFR.dump command creates a clone of the original recording, but maxage and maxsize parameters are not copied to the clone in PlatformRecording.newSnapshotClone(). When PlatformRecording.appendChunk() is called for the clone to append the latest data, trimToAge() and trimToSize() are not performed because maxAge and maxSize are not set. Therefore the clone sometimes dumps outdated chunks to the disk. Testing: ------------- Commit messages: Changes: https://git.openjdk.java.net/jdk/pull/239/files PR: https://git.openjdk.java.net/jdk/pull/239 |
@kvergizova This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 442 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@egahlin) but any other Committer may sponsor as well.
|
/integrate |
@kvergizova |
/sponsor |
@VladimirKempik @kvergizova Since your change was applied there have been 442 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit a0382cd. |
JFR.dump command creates a clone of the original recording, but maxage and maxsize parameters are not copied to the clone in PlatformRecording.newSnapshotClone().
When PlatformRecording.appendChunk() is called for the clone to append the latest data, trimToAge() and trimToSize() are not performed because maxAge and maxSize are not set.
Therefore the clone sometimes dumps outdated chunks to the disk.
Testing:
jdk/jdk/jfr/*
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/239/head:pull/239
$ git checkout pull/239