8350542: Optional.orElseThrow(Supplier) does not specify behavior when supplier returns null

[gustavosimon]

Javadoc for java.util.Optional.orElseThrow(Supplier) misses mentioning of another possible cause of a NullPointerException - when the exception supplying function returns a null result.

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change requires CSR request JDK-8354953 to be approved
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Error

 ⚠️ The pull request body must not be empty.

Issues

• JDK-8350542: Optional.orElseThrow(Supplier) does not specify behavior when supplier returns null (Enhancement - P4)
• JDK-8354953: Optional.orElseThrow(Supplier) does not specify behavior when supplier returns null (CSR)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23905/head:pull/23905
$ git checkout pull/23905

Update a local copy of the PR:
$ git checkout pull/23905
$ git pull https://git.openjdk.org/jdk.git pull/23905/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23905

View PR using the GUI difftool:
$ git pr show -t 23905

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23905.diff

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change requires CSR request JDK-8354953 to be approved
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issues

• JDK-8350542: Optional.orElseThrow(Supplier) does not specify behavior when supplier returns null (Enhancement - P4)
• JDK-8354953: Optional.orElseThrow(Supplier) does not specify behavior when supplier returns null (CSR)

Reviewers

• Chen Liang (@liach - Reviewer)
• Christoph Langer (@RealCLanger - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23905/head:pull/23905
$ git checkout pull/23905

Update a local copy of the PR:
$ git checkout pull/23905
$ git pull https://git.openjdk.org/jdk.git pull/23905/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23905

View PR using the GUI difftool:
$ git pr show -t 23905

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23905.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

Hi @gustavosimon, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user gustavosimon" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

[openjdk]

@gustavosimon This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8350542: Optional.orElseThrow(Supplier) does not specify behavior when supplier returns null

Reviewed-by: liach, clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 862 new commits pushed to the master branch:

• e4cb49f: 8342206: Convenience method to check if a constant pool entry matches nominal descriptors
• 7bde2bb: 8355654: RISC-V: Relax register constraint for some vector-scalar instructions
• 7cf190f: 8345225: AARCH64: VM crashes with -NearCpool +UseShenandoahGC options
• ... and 859 more: https://git.openjdk.org/jdk/compare/6a31aaeb00b6c37e2e19c5f2759c4aa9ed87f25a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@liach, @RealCLanger) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@gustavosimon The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[gustavosimon]

@robilad As you asked, I have already sent you an e-mail verify my OCA. I will need for this PR. Cheers, looking forward! 😀

[liach]

/csr

Since this changes API specification text, we will need a small CSR for archival purposes noting the specification change. @RealCLanger since you have assigned yourself on the JBS, you might help with the CSR process too.

[openjdk]

@liach has indicated that a compatibility and specification (CSR) request is needed for this pull request.

@gustavosimon please create a CSR request for issue JDK-8350542 with the correct fix version. This pull request cannot be integrated until the CSR request is approved.

[gustavosimon]

@robilad As you asked, I have already sent you an e-mail verify my OCA. I will need for this PR. Cheers, looking forward! 😀

@robilad Any luck into this matter?

[liach]

You can comment

/oca verify

and see if it's handled.

[gustavosimon]

/oca verify

[openjdk]

@gustavosimon Unknown command oca - for a list of valid commands use /help.

[liach]

Oops sorry, it should be

/signed

[gustavosimon]

@liach oca appears to be not recognized by bot

[gustavosimon]

The fastest GH's reply was made now! hahaha

[gustavosimon]

/signed

[bridgekeeper]

Thank you! Please allow for up to two weeks to process your OCA, although it is usually done within one to two business days. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

[gustavosimon]

/signed

[bridgekeeper]

Already processed the signed command

[gustavosimon]

@liach I think @robilad didn't verified my account. How should I proceed?

[liach]

I think Dalibor might be busy - You might email him again on the progress.

[gustavosimon]

Hello @liach! I'm going to email @robilad.

[RealCLanger]

I have created a CSR: https://bugs.openjdk.org/browse/JDK-8354953

[gustavosimon]

/signed

[bridgekeeper]

Already processed the signed command

[gustavosimon]

@liach and @RealCLanger what's the next step to merge this into master?

[gustavosimon]

@RealCLanger I will do it today. The CSR seems to be approved now - then I just need to push the change to merge it.

[liach]

Also please add some of your own text to the pull request body, like the first sentence of the issue report:

Javadoc for java.util.Optional.orElseThrow(Supplier) misses mentioning of another possible cause of a NullPointerException - when the exception supplying function returns a null result.

Once you have pushed the changes, Chris or I may review this for integration.

[gustavosimon]

@liach now the PR is ready for review. We're almost there! 🔝

[mlbridge]

Webrevs

• 01: Full - Incremental (32448774)
• 00: Full (53df7aff)

[gustavosimon]

@liach @RogerRiggs Sorry, I forgot a part of the specification! Now we are ready!

[liach]

Looks good.

[openjdk]

⚠️ @gustavosimon the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout 8350542
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

[gustavosimon]

/integrate

[openjdk]

@gustavosimon
Your change (at version 3244877) is now ready to be sponsored by a Committer.

[gustavosimon]

@liach Can't I integrate?

[RealCLanger]

@liach Can't I integrate?

When you are not a committer, some committer needs to sponsor it for you. I'm doing it. 😄

/sponsor

[openjdk]

Going to push as commit 44374a5.
Since your change was applied there have been 862 commits pushed to the master branch:

• e4cb49f: 8342206: Convenience method to check if a constant pool entry matches nominal descriptors
• 7bde2bb: 8355654: RISC-V: Relax register constraint for some vector-scalar instructions
• 7cf190f: 8345225: AARCH64: VM crashes with -NearCpool +UseShenandoahGC options
• ... and 859 more: https://git.openjdk.org/jdk/compare/6a31aaeb00b6c37e2e19c5f2759c4aa9ed87f25a...master

Your commit was automatically rebased without conflicts.

[openjdk]

@RealCLanger @gustavosimon Pushed as commit 44374a5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.