8351256: Improve printing of runtime call stub names in disassember output

[adinn]

Fixes printing of runtime stub call targets in disassembler listings.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8351256: Improve printing of runtime call stub names in disassember output (Enhancement - P4)

Reviewers

• Vladimir Kozlov (@vnkozlov - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23915/head:pull/23915
$ git checkout pull/23915

Update a local copy of the PR:
$ git checkout pull/23915
$ git pull https://git.openjdk.org/jdk.git pull/23915/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23915

View PR using the GUI difftool:
$ git pr show -t 23915

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23915.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back adinn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@adinn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8351256: Improve printing of runtime call stub names in disassember output

Reviewed-by: kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

• 11a37c8: 8351165: Remove unused includes from vmStructs
• c3b4819: 8351074: Disallow null prefix and suffix in DecimalFormat
• 6012e8d: 8350808: Small typos in JShell method SnippetEvent.toString()
• 661bd5b: 8343478: Remove unnecessary @SuppressWarnings annotations (core-libs)
• 61d9ab9: 8350854: Include thread counts in safepoint logging
• ea9e3cf: 8281511: java/net/ipv6tests/UdpTest.java fails with checkTime failed
• caaf409: 8350546: Several java/net/InetAddress tests fails UnknownHostException
• 062b7c7: 8351115: Test AOTClassLinkingVMOptions.java fails after JDK-8348322
• a88e8cd: 8350952: Remove some non present files from OPT_SPEED_SRC list
• de29ef3: 8343191: Cgroup v1 subsystem fails to set subsystem path
• ... and 1 more: https://git.openjdk.org/jdk/compare/b1a21b563e3ae13fa5c409a4f0c04686c3f5b34a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@adinn The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (8f774199)
• 00: Full (f976e016)

[adinn]

Verified by eyeball:

$ java -XX:CompileCommand='print,java.lang.Object::<init>' Hello
CompileCommand: print java/lang/Object.<init> bool print = true
  . . .
Compiled method (c1) 98    1       3       java.lang.Object::<init> (1 bytes)
  . . .
  0x0000ffff670001b8:   cmp	x8, x9
  0x0000ffff670001bc:   b.eq	0x0000ffff670001d8  // b.none
 ;; 0xFFFF6E59EAC0
  0x0000ffff670001c0:   mov	x8, #0xeac0                	// #60096
                                                            ;   {runtime_call Stub::method_entry_barrier}
  0x0000ffff670001c4:   movk	x8, #0x6e59, lsl #16
  0x0000ffff670001c8:   movk	x8, #0xffff, lsl #32
  0x0000ffff670001cc:   blr	x8
  . . .

[adinn]

/author @vnkozlov

[openjdk]

@adinn
Setting overriding author to Vladimir Kozlov <kvn@openjdk.org>. When this pull request is integrated, the overriding author will be used in the commit.

[vnkozlov]

Good. Thank you for fast PR submission.

[vnkozlov]

👎 I can't be reviewer if I am author.

[vnkozlov]

@adinn Can you add additional change to relocInfo.cpp to print call resolution blobs ?:
vnkozlov@620b99f

[vnkozlov]

And one more in nmethod.cpp which fixes the issue in both, mainline and leyden.
RelocInfo::none may point to the same address as following relocation info:

         @0x000000010ec23436: 0002
relocInfo@0x000000010ec23436 [type=0(none) addr=0x000000010ec234c8 offset=8]
         @0x000000010ec23438: 3000
relocInfo@0x000000010ec23438 [type=6(runtime_call) addr=0x000000010ec234c8 offset=0] | [destination=0x000000010ec1f400] Blob::ExceptionBlob

As result the real relocation info for this address is not printed:

[Exception Handler]
  0x000000010ca8c1c8:   adrp            x8, #0x10ca85000    ;   {no_reloc}

The fix:

@@ -3550,7 +3550,10 @@ const char* nmethod::reloc_string_for(u_char* begin, u_char* end) {
   while (iter.next()) {
     have_one = true;
     switch (iter.type()) {
-        case relocInfo::none:                  return "no_reloc";
+        case relocInfo::none: {
+          // Skip it and check next
+          break;
+        }
         case relocInfo::oop_type: {
           // Get a non-resizable resource-allocated stringStream.
           // Our callees make use of (nested) ResourceMarks.

After fix:

[Exception Handler]
  0x000000010ec234c8:   adrp            x8, #0x10ec1f000    ;   {runtime_call ExceptionBlob}

[adinn]

/author @adinn

[openjdk]

@adinn
Setting overriding author to Andrew Dinn <adinn@openjdk.org>. When this pull request is integrated, the overriding author will be used in the commit.

[adinn]

@vnkozlov I pushed the recommended fixes for both reloc info and nmethod.

[vnkozlov]

Looks good.

[adinn]

/integrate

[openjdk]

Going to push as commit cfab88b.
Since your change was applied there have been 19 commits pushed to the master branch:

• 7a5acb9: 8343840: Rewrite the ObjectMonitor lists
• 40f150d: 8330936: [ubsan] exclude function BilinearInterp and ShapeSINextSpan in libawt java2d from ubsan checks
• 649ef77: 8323158: HotSpot Style Guide should specify more include ordering
• 5c552a9: 8349358: [JMH] Cannot access class jdk.internal.vm.ContinuationScope
• e82031e: 8350756: C2 SuperWord Multiversioning: remove useless slow loop when the fast loop disappears
• 3626ac3: 8204868: java/util/zip/ZipFile/TestCleaner.java still fails with "cleaner failed to clean zipfile."
• 4bb3d81: 8351138: Running subset of gtests gets error printing result information
• 107ee87: 8346954: [JMH] jdk.incubator.vector.MaskedLogicOpts fails due to IndexOutOfBoundsException
• 11a37c8: 8351165: Remove unused includes from vmStructs
• c3b4819: 8351074: Disallow null prefix and suffix in DecimalFormat
• ... and 9 more: https://git.openjdk.org/jdk/compare/b1a21b563e3ae13fa5c409a4f0c04686c3f5b34a...master

Your commit was automatically rebased without conflicts.

[openjdk]

@adinn Pushed as commit cfab88b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.