8350460: org.openjdk.bench.vm.floatingpoint.DremFrem JMH fails with -ea

[ericcaspole]

The normal SQE process runs all the repo JMH with -ea to get the last bit of extra testing. This DremFrem JMH contained some asserts that would always fire on the correct answer, disturbing this normal SQE process. I removed a lot more asserts from this JMH which seemed to make it more of a SQE test than a benchmark. We would prefer to keep benchmarks as benchmarks as much as possible and not creep into tests.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8350460: org.openjdk.bench.vm.floatingpoint.DremFrem JMH fails with -ea (Bug - P4)

Reviewers

• Chen Liang (@liach - Reviewer)
• Joe Darcy (@jddarcy - Reviewer) Review applies to 8c882666

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23917/head:pull/23917
$ git checkout pull/23917

Update a local copy of the PR:
$ git checkout pull/23917
$ git pull https://git.openjdk.org/jdk.git pull/23917/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23917

View PR using the GUI difftool:
$ git pr show -t 23917

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23917.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ecaspole! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@ericcaspole This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8350460: org.openjdk.bench.vm.floatingpoint.DremFrem JMH fails with -ea

Reviewed-by: liach, darcy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 36 new commits pushed to the master branch:

• 8ed6c1d: 8350607: Consolidate MethodHandles::zero into MethodHandles::constant
• f6a8db2: 8348261: assert(n->is_Mem()) failed: memory node required
• 5cd4fe6: 8348309: MultiNST tests need more debugging and timing
• 7c22b81: 8350811: [JMH] test foreign.StrLenTest failed with StringIndexOutOfBoundsException for size=451
• 54fe643: 8347433: Deprecate XML interchange in java.management/javax/management/modelmbean/DescriptorSupport for removal
• 155697f: 8349623: [ASAN] Gtest os_linux.glibc_mallinfo_wrapper_vm fails
• 4066f33: 8350565: NMT: remaining memory flag/type to be replaced with memory tag
• 7314efc: 8351377: Fix the ProblemList for com/sun/management/OperatingSystemMXBean cpuLoad tests on AIX
• 7c9a784: 8351223: Update localized resources in keytool and jarsigner
• a23fb0a: 8348110: Update LCMS to 2.17
• ... and 26 more: https://git.openjdk.org/jdk/compare/38b4d46c1ff3701d75ff8347e5edbb01acd9b512...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@ericcaspole To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels

• build
• client
• compiler
• core-libs
• graal
• hotspot
• hotspot-compiler
• hotspot-gc
• hotspot-jfr
• hotspot-runtime
• i18n
• ide-support
• javadoc
• jdk
• jmx
• kulla
• net
• nio
• security
• serviceability
• shenandoah

[ericcaspole]

/label core-libs compiler

[openjdk]

@ericcaspole
The core-libs label was successfully added.

The compiler label was successfully added.

[mlbridge]

Webrevs

• 01: Full - Incremental (649957dc)
• 00: Full (8c882666)

[liach]

@ericcaspole Do you mean hotspot-compiler for the label instead of javac?

[liach]

These benchmarks are malformed indeed; the blackhole is never used.

[liach]

Also might need to add an 2025 copyright header for this file.

[ericcaspole]

Thanks @liach I removed the unused Blackhole and updated the copyright header.

[ericcaspole]

If these last cleanups are OK could I get one last Reviewer rubber stamp? TIA

[liach]

Indeed, these tests uses a static non-final field as the sink of work, which should be equivalent to using a blackhole. We can remove this unused blackhole safely.

[ericcaspole]

/integrate

[openjdk]

Going to push as commit 76e0f30.
Since your change was applied there have been 37 commits pushed to the master branch:

• 4e67ac4: 8350909: [JMH] test ThreadOnSpinWaitShared failed for 2 threads config
• 8ed6c1d: 8350607: Consolidate MethodHandles::zero into MethodHandles::constant
• f6a8db2: 8348261: assert(n->is_Mem()) failed: memory node required
• 5cd4fe6: 8348309: MultiNST tests need more debugging and timing
• 7c22b81: 8350811: [JMH] test foreign.StrLenTest failed with StringIndexOutOfBoundsException for size=451
• 54fe643: 8347433: Deprecate XML interchange in java.management/javax/management/modelmbean/DescriptorSupport for removal
• 155697f: 8349623: [ASAN] Gtest os_linux.glibc_mallinfo_wrapper_vm fails
• 4066f33: 8350565: NMT: remaining memory flag/type to be replaced with memory tag
• 7314efc: 8351377: Fix the ProblemList for com/sun/management/OperatingSystemMXBean cpuLoad tests on AIX
• 7c9a784: 8351223: Update localized resources in keytool and jarsigner
• ... and 27 more: https://git.openjdk.org/jdk/compare/38b4d46c1ff3701d75ff8347e5edbb01acd9b512...master

Your commit was automatically rebased without conflicts.

[openjdk]

@ericcaspole Pushed as commit 76e0f30.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.