Skip to content

8351294: (fs) Minor verbiage correction for Files.createTemp{Directory,File}#23919

Closed
bplb wants to merge 1 commit intoopenjdk:masterfrom
bplb:Files-createTemp-8351294
Closed

8351294: (fs) Minor verbiage correction for Files.createTemp{Directory,File}#23919
bplb wants to merge 1 commit intoopenjdk:masterfrom
bplb:Files-createTemp-8351294

Conversation

@bplb
Copy link
Member

@bplb bplb commented Mar 5, 2025

Modernize some verbiage from the Pliocene epoch: "to" becomes "than".


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8351294: (fs) Minor verbiage correction for Files.createTemp{Directory,File} (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23919/head:pull/23919
$ git checkout pull/23919

Update a local copy of the PR:
$ git checkout pull/23919
$ git pull https://git.openjdk.org/jdk.git pull/23919/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23919

View PR using the GUI difftool:
$ git pr show -t 23919

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23919.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 5, 2025

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 5, 2025

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8351294: (fs) Minor verbiage correction for Files.createTemp{Directory,File}

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • 5c552a9: 8349358: [JMH] Cannot access class jdk.internal.vm.ContinuationScope
  • e82031e: 8350756: C2 SuperWord Multiversioning: remove useless slow loop when the fast loop disappears
  • 3626ac3: 8204868: java/util/zip/ZipFile/TestCleaner.java still fails with "cleaner failed to clean zipfile."
  • 4bb3d81: 8351138: Running subset of gtests gets error printing result information
  • 107ee87: 8346954: [JMH] jdk.incubator.vector.MaskedLogicOpts fails due to IndexOutOfBoundsException
  • 11a37c8: 8351165: Remove unused includes from vmStructs
  • c3b4819: 8351074: Disallow null prefix and suffix in DecimalFormat
  • 6012e8d: 8350808: Small typos in JShell method SnippetEvent.toString()
  • 661bd5b: 8343478: Remove unnecessary @SuppressWarnings annotations (core-libs)

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 5, 2025
@dfuch
Copy link
Member

dfuch commented Mar 5, 2025

Thanks Brian - it reads better to me.

@openjdk
Copy link

openjdk bot commented Mar 5, 2025

@bplb The following label will be automatically applied to this pull request:

  • nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the nio nio-dev@openjdk.org label Mar 5, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 5, 2025

Webrevs

@bplb
Copy link
Member Author

bplb commented Mar 5, 2025

Thanks Brian - it reads better to me.

Thanks for noticing it.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 6, 2025
@bplb
Copy link
Member Author

bplb commented Mar 6, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Mar 6, 2025

Going to push as commit 93f2260.
Since your change was applied there have been 14 commits pushed to the master branch:

  • 8f8a879: 8350939: Revisit Windows PDH buffer size calculation for OperatingSystemMXBean
  • cfab88b: 8351256: Improve printing of runtime call stub names in disassember output
  • 7a5acb9: 8343840: Rewrite the ObjectMonitor lists
  • 40f150d: 8330936: [ubsan] exclude function BilinearInterp and ShapeSINextSpan in libawt java2d from ubsan checks
  • 649ef77: 8323158: HotSpot Style Guide should specify more include ordering
  • 5c552a9: 8349358: [JMH] Cannot access class jdk.internal.vm.ContinuationScope
  • e82031e: 8350756: C2 SuperWord Multiversioning: remove useless slow loop when the fast loop disappears
  • 3626ac3: 8204868: java/util/zip/ZipFile/TestCleaner.java still fails with "cleaner failed to clean zipfile."
  • 4bb3d81: 8351138: Running subset of gtests gets error printing result information
  • 107ee87: 8346954: [JMH] jdk.incubator.vector.MaskedLogicOpts fails due to IndexOutOfBoundsException
  • ... and 4 more: https://git.openjdk.org/jdk/compare/61d9ab9717783e5bb0faa555f794499d0e5b3fdb...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 6, 2025
@openjdk openjdk bot closed this Mar 6, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 6, 2025
@openjdk
Copy link

openjdk bot commented Mar 6, 2025

@bplb Pushed as commit 93f2260.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@bplb bplb deleted the Files-createTemp-8351294 branch March 11, 2025 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated nio nio-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

3 participants