Skip to content

8351233: [ASAN] avx2-emu-funcs.hpp:151:20: error: ‘D.82188’ is used uninitialized #23925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Mar 6, 2025

Hi all,

The return type of function const __m256i &perm is __m256i, so const __m256i &perm should be replaced as 'const __m256i perm'.

The function implementation in gcc/clang compiler header:

  1. gcc: lib/gcc/x86_64-pc-linux-gnu/14.2.0/include/avxintrin.h
extern __inline __m256i __attribute__((__gnu_inline__, __always_inline__, __artificial__))
_mm256_loadu_si256 (__m256i_u const *__P)
{
  return *__P;
}
  1. clang: lib64/clang/17/include/avxintrin.h
static __inline __m256i __DEFAULT_FN_ATTRS
_mm256_loadu_si256(__m256i_u const *__p)
{
  struct __loadu_si256 {
    __m256i_u __v;
  } __attribute__((__packed__, __may_alias__));
  return ((const struct __loadu_si256*)__p)->__v;
}

Additional testing:

  • jtreg tests(include tier1/2/3 etc.) on linux-x64(AMD EPYC 9T24 96-Core Processor) with release build
  • jtreg tests(include tier1/2/3 etc.) on linux-x64(AMD EPYC 9T24 96-Core Processor) with fastdebug build

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8351233: [ASAN] avx2-emu-funcs.hpp:151:20: error: ‘D.82188’ is used uninitialized (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23925/head:pull/23925
$ git checkout pull/23925

Update a local copy of the PR:
$ git checkout pull/23925
$ git pull https://git.openjdk.org/jdk.git pull/23925/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23925

View PR using the GUI difftool:
$ git pr show -t 23925

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23925.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 6, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 6, 2025

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8351233: [ASAN] avx2-emu-funcs.hpp:151:20: error: ‘D.82188’ is used uninitialized

Reviewed-by: vlivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 305 new commits pushed to the master branch:

  • 3d2c3cd: 8352970: Remove unnecessary Windows version check in Win32ShellFolderManager2
  • c70ad6a: 8352906: stdout/err.encoding on Windows set by incorrect Win32 call
  • da3bb06: 8352685: Opensource JInternalFrame tests - series2
  • d809033: 8341775: Duplicate manifest files are removed by jarsigner after signing
  • a269bef: 8350459: MontgomeryIntegerPolynomialP256 multiply intrinsic with AVX2 on x86_64
  • c029220: 8352896: LambdaExpr02.java runs wrong test class
  • c0b61d3: 8352680: Opensource few misc swing tests
  • 3e9a7a4: 8353063: make/ide/vscode: Invalid Configuration Values
  • 8ef7832: 8350471: Unhandled compilation bailout in GraphKit::builtin_throw
  • ddf326b: 8346888: [ubsan] block.cpp:1617:30: runtime error: 9.97582e+36 is outside the range of representable values of type 'int'
  • ... and 295 more: https://git.openjdk.org/jdk/compare/4bb3d81479c1bbe2c6fc7b5234d0f1b6897be117...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 6, 2025
@openjdk
Copy link

openjdk bot commented Mar 6, 2025

@sendaoYan To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@sendaoYan
Copy link
Member Author

@vamsi-parasa Could you take look this PR

@sendaoYan
Copy link
Member Author

/label add core-libs

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Mar 6, 2025
@openjdk
Copy link

openjdk bot commented Mar 6, 2025

@sendaoYan
The core-libs label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Mar 6, 2025

Webrevs

@sendaoYan
Copy link
Member Author

GHA report 1 test failure:

  1. Job 'macos-aarch64 hs/tier1 gc' report "gc/TestAllocHumongousFragment.java#generational" timed out, this issue has been recorded by JDK-8345958, it's unrelated to this PR.

@sendaoYan
Copy link
Member Author

/label add hotspot-compiler

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Mar 7, 2025
@openjdk
Copy link

openjdk bot commented Mar 7, 2025

@sendaoYan
The hotspot-compiler label was successfully added.

Copy link
Contributor

@iwanowww iwanowww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. (I'll submit it for testing.)

Copy link
Contributor

@iwanowww iwanowww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing results (hs-tier1 - hs-tier4) are clean.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 29, 2025
@sendaoYan
Copy link
Member Author

GHA test failures are unrelated to this PR. Thanks for the reviews @iwanowww

/integrate

@openjdk
Copy link

openjdk bot commented Mar 30, 2025

Going to push as commit 895aabc.
Since your change was applied there have been 305 commits pushed to the master branch:

  • 3d2c3cd: 8352970: Remove unnecessary Windows version check in Win32ShellFolderManager2
  • c70ad6a: 8352906: stdout/err.encoding on Windows set by incorrect Win32 call
  • da3bb06: 8352685: Opensource JInternalFrame tests - series2
  • d809033: 8341775: Duplicate manifest files are removed by jarsigner after signing
  • a269bef: 8350459: MontgomeryIntegerPolynomialP256 multiply intrinsic with AVX2 on x86_64
  • c029220: 8352896: LambdaExpr02.java runs wrong test class
  • c0b61d3: 8352680: Opensource few misc swing tests
  • 3e9a7a4: 8353063: make/ide/vscode: Invalid Configuration Values
  • 8ef7832: 8350471: Unhandled compilation bailout in GraphKit::builtin_throw
  • ddf326b: 8346888: [ubsan] block.cpp:1617:30: runtime error: 9.97582e+36 is outside the range of representable values of type 'int'
  • ... and 295 more: https://git.openjdk.org/jdk/compare/4bb3d81479c1bbe2c6fc7b5234d0f1b6897be117...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 30, 2025
@openjdk openjdk bot closed this Mar 30, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 30, 2025
@openjdk
Copy link

openjdk bot commented Mar 30, 2025

@sendaoYan Pushed as commit 895aabc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sendaoYan sendaoYan deleted the jbs8351233 branch March 30, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants